Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2075 closed defect (implemented)

Simplify get_predicted_ports logic in rephist

Reported by: nickm Owned by:
Priority: Very Low Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The old predicted ports code keeping two lists of items in synch by index. That makes for complexity! Instead, it's far simpler to keep a single list whose elements are a struct containing the two items kept in the two old lists.

Please review branch "refactor_pports" in my public repository.

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by nickm

Status: newneeds_review

comment:2 Changed 9 years ago by Sebastian

Looks good to me.

comment:3 Changed 9 years ago by nickm

Milestone: Tor: 0.2.3.x-final

comment:4 Changed 9 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

It looks good to sebastian, and it still looks good to me. Let's merge it into 0.2.3

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.