Opened 3 years ago

Closed 3 years ago

#20753 closed defect (fixed)

remove obsolete localization strings

Reported by: arthuredelstein Owned by: arthurdedelstein
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201611R
Cc: Phoul Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Discussing our Startpage strings with Phoul, I noticed they are no longer in use. We should remove them and any other obsolete strings to minimize the burden on translators.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201610R added
Status: newneeds_review

comment:2 in reply to:  1 Changed 3 years ago by gk

Keywords: TorBrowserTeam201611 added; TorBrowserTeam201610R removed
Owner: changed from arthuredelstein to arthurdedelstein
Status: needs_reviewassigned

Replying to arthuredelstein:

Here's my patch:
https://github.com/arthuredelstein/tor-browser/commit/20753

I only get a 404 not found. Did you forget to push?

comment:3 Changed 3 years ago by gk

Keywords: TorBrowserTeam201611R added; TorBrowserTeam201611 removed
Status: assignedneeds_review

Aha, this was in your Torbutton repo it seems.

comment:4 Changed 3 years ago by gk

What is with the one in aboutTor.dtd (i.e. aboutTor.searchSPPost.link)?

comment:5 in reply to:  4 Changed 3 years ago by arthuredelstein

Replying to gk:

What is with the one in aboutTor.dtd (i.e. aboutTor.searchSPPost.link)?

Yes, good idea. Here's the new branch, in the correct repo:
https://github.com/arthuredelstein/torbutton/commit/20753+1

comment:6 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed with commit 88cf6251a1ca3c02361673f9a5d542290382c998, thanks.

Note: See TracTickets for help on using tickets.