Opened 3 years ago

Last modified 21 months ago

#20796 new defect

TorFlow's ScanHandler can divide by zero when there are no unmeasured nodes

Reported by: teor Owned by:
Priority: Medium Milestone:
Component: Core Tor/pytorctl Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #24225 Points:
Reviewer: Sponsor:

Description

When ScanHandler tries to convert a rank to a percent, and there are no unmeasured nodes, it divides by zero.

Child Tickets

Attachments (1)

0008-Avoid-division-by-zero-and-excessive-ranks-in-ScanHa.patch (1.2 KB) - added by teor 3 years ago.
Patch for this issue

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by teor

Patch for this issue

comment:1 Changed 3 years ago by teor

Status: newneeds_review

comment:2 Changed 3 years ago by tom

This is in testing. (I'm surprised we don't have a pytorctl component.)

comment:3 Changed 2 years ago by tom

I'm ready to accept this patch but I don't have the ability to commit to pytorctl.

comment:4 in reply to:  2 Changed 2 years ago by teor

Component: Metrics/TorflowMetrics/pytorctl

Replying to tom:

This is in testing. (I'm surprised we don't have a pytorctl component.)

We do now. (I hope karsten doesn't mind me adding it.)

comment:5 in reply to:  3 Changed 2 years ago by teor

Status: needs_reviewmerge_ready

Replying to tom:

I'm ready to accept this patch but I don't have the ability to commit to pytorctl.

I opened #21791 for this.

comment:6 Changed 22 months ago by teor

Owner: changed from aagbsn to teor
Status: merge_readyassigned

comment:7 Changed 22 months ago by teor

Status: assignedmerge_ready

comment:8 Changed 22 months ago by teor

Parent ID: #24225

After we commit this, we need to update the TorCtl submodule in torflow, see #24225.

comment:9 Changed 21 months ago by teor

Owner: teor deleted
Status: merge_readyassigned

Disowning tickets I don't intend to work on in the next 6 months.

comment:10 Changed 21 months ago by teor

Status: assignednew

Mark all tickets that are assigned to nobody as "new".

Note: See TracTickets for help on using tickets.