Opened 3 years ago

Closed 3 years ago

#20803 closed defect (fixed)

recommended-client-protocols and related are not in dir-spec

Reported by: tom Owned by:
Priority: Low Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, review-group-13
Cc: atagar Actual Points:
Parent ID: Points: 0.1
Reviewer: nickm Sponsor:

Description

The network protocols were implemented in consensus voting in #19958, but they were not added to dir-spec.txt. (See also #20789)

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by dgoulet

Keywords: spec added
Milestone: Tor: 0.3.0.x-final
Points: 0.1

comment:2 Changed 3 years ago by asn

Keywords: tor-spec added; spec removed

comment:3 Changed 3 years ago by atagar

On a side note, please make an effort to keep the spec up to date soon after things go into tor. As far as I'm concerned the presence of fields like this in descriptors is a tor bug until they do.

comment:4 Changed 3 years ago by dgoulet

Status: newneeds_review

Here is an attempt: ticket20803_01.

First commit merges it in dir-spec and tor-spec and then second commit closes the proposal. With this, reserving subprotocol version is made in section 9 of tor-spec.txt.

comment:5 Changed 3 years ago by atagar

Thanks dgoulet! On first glance looks good. I'll merge this while adding Stem support (implementing that will be a good exercise to triple check that this spec addition covers everything).

comment:6 Changed 3 years ago by nickm

Keywords: review-group-13 added

comment:7 Changed 3 years ago by nickm

Reviewer: nickm

comment:8 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged!

Note: See TracTickets for help on using tickets.