Opened 3 years ago

Closed 2 years ago

#20804 closed defect (fixed)

Make the progress dialog box `Cancel` operation more robust.

Reported by: yawning Owned by: yawning
Priority: Medium Milestone:
Component: Archived/Tor Browser Sandbox Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #20783 Points:
Reviewer: Sponsor:

Description

The progress dialog I use, along with the async task thing I cobbled together is still somewhat race prone and fragile, and sometimes leaves the dialog box up instead of hiding it.

I mostly see this when testing on my VM. The code in general could use an overhaul and cleanup since it's kind of kludged together.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by yawning

Till I have time to untangle that mess of channel operations, I just put in a kludge that increases channel capacity to avoid blocking on writes. It seems to mostly mask the issue on my VM, though that's with light testing, and this really should be cleaned up and fixed properly.

https://gitweb.torproject.org/tor-browser/sandboxed-tor-browser.git/commit/?id=22c94991236e6dff096e29fbb6e74c5a1d20c912

comment:2 Changed 2 years ago by yawning

Resolution: fixed
Status: newclosed

This is probably sufficient for now, the entire UI code needs a rewrite at some point anyway.

Note: See TracTickets for help on using tickets.