Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2081 closed defect (fixed)

Remove restriction to not send relay_early for rend circs

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Back in bug #1038 we added a restriction not to send relay_early cells on rends circuits. The time without relays running versions 0.2.1.3-alpha through 0.2.1.18-alpha has come, so it should be fine to lift the restriction now.

Child Tickets

Change History (18)

comment:1 Changed 9 years ago by Sebastian

Status: newneeds_review

Branch relay_early_rend in my repository for a suggested fix. This is on maint-0.2.2, but it also applies cleanly to master. I think it might want to go into maint.

comment:2 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Merging to 0.2.2 and master.

comment:3 Changed 9 years ago by arma

Resolution: fixed
Status: closedreopened

comment:4 Changed 9 years ago by arma

Does that mean we should change dirserv_get_status_impl() so it refuses descriptors from relays running these versions?

(Just because nobody's running these versions now doesn't mean nobody will run them in the future.)

comment:5 Changed 9 years ago by Sebastian

We could. If you set them up maliciously, you get better ways to screw with users. I checked that all distributions have earlier/later versions. I didn't think it was necessary due to these conditions

comment:6 Changed 9 years ago by nickm

Milestone: Tor: 0.2.2.x-final

comment:7 Changed 9 years ago by nickm

Status: reopenedneeds_review

See branch bug2081_followup_022 in my public repository.

comment:8 Changed 9 years ago by Sebastian

Looks good to me. Maybe we want to incorporate the #2156 fix here, too?

comment:9 Changed 9 years ago by nickm

I wouldn't object. What's the oldest 0.2.0.x that doesn't scare us?

comment:10 Changed 9 years ago by Sebastian

We currently have no active 0.2.0.x relays running anything below 0.2.0.32, so we could safely raise to at least 0.2.0.32. In .33, we fixed Ilja's bug. .34 fixes a remote crash on exits. We have 5 relays running 0.2.0.3[23]. Does either bug scare us enough or do we raise to .32?

comment:11 Changed 9 years ago by nickm

I'm not too scared. I would like a second opinion from arma though.

comment:12 in reply to:  7 Changed 9 years ago by rransom

Replying to nickm:

See branch bug2081_followup_022 in my public repository.

The source code patch looks ‘obviously correct’ to me, but there are two typos in the changes file:

2s/server/servers/
4s/RELAY_EARY/RELAY_EARLY/

comment:13 Changed 9 years ago by arma

There's also s/verions/versions/

We might also say s/server/relay/g

comment:14 Changed 9 years ago by arma

I should point out that we now have Tor relays in the consensus running these versions:

r Bellum 7j/MKmnxheiRBy8T7pkIzW7ZvqU w2+LIXCt6qZeib6tsLY/BvrxM70 2010-12-06 23:37:14 62.75.223.163 9001 0
s Fast Named Running Stable Valid
v Tor 0.2.1.12-alpha (r18423)
w Bandwidth=16900
p reject 1-65535
r sutor yqIADJ1riF5y3j6ckVdjwM0xmS4 Q/JSbIGYIOmNLDVLOEMq394KnSQ 2010-12-06 13:22:40 62.193.210.68 443 0
s Fast Named Running Valid
v Tor 0.2.1.16-rc
w Bandwidth=30
p reject 1-65535

So a) perhaps these versions aren't really dead yet, and b) once we do deploy sebastian's "relay_early_rend" (looks like we already did), we really will want to lock out Tor relays with these versions.

comment:15 Changed 9 years ago by nickm

So is that a "go ahead", or "hang on", or "I want to think more" ?

comment:16 Changed 9 years ago by arma

It's an "in retrospect, maybe we should have not applied the relay_early_rend patch yet".

But that said, we did, so we should apply the next patch too.

Once we do lock these versions out, we should make a stronger effort to monitor the logs on directory authorities to recognize when people are trying to publish, and try to contact them to help them realize they should upgrade.

comment:17 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

cleaned up changes file and merged.

comment:18 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.