Opened 4 years ago

Closed 4 years ago

#20810 closed defect (fixed)

protover: Using twice the same version for old tor

Reported by: dgoulet Owned by:
Priority: High Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: 029-backport, review-group-13
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: nickm Sponsor:


protover_compute_for_old_tor() checks twice version leading to dead code.

According to the comment and the spec, it should be

  } else if (tor_version_as_new_as(version, "")) {
    /* HSRend=2 */
    return "Cons=1-2 Desc=1-2 DirCache=1 HSDir=1 HSIntro=3 HSRend=1-2 "
      "Link=1-4 LinkAuth=1 "
      "Microdesc=1-2 Relay=1-2";

Patch coming up.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by dgoulet

Status: newneeds_review

See branch bug20810_030_01

comment:2 Changed 4 years ago by nickm

Keywords: review-group-13 added

comment:3 Changed 4 years ago by nickm

Reviewer: nickm

comment:4 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good, but cherry-picked into 0.2.9, so that the authorities can start getting it right as they upgrade.

Note: See TracTickets for help on using tickets.