-
- View options
Activity
We might want to fix this one for #16874 (moved) (and similar websites). See:
or the links in comment:7:ticket:16874.
Trac:
Keywords: N/A deleted, TorBrowserTeam201509, GeorgKoppen201509 added
Status: new to assigned
Owner: tbb-team to gk
Since adding a simple C++ implementation of the Intl API seems like a big task (please discuss that idea in #16874 (moved)), I spent a little time trying to learn about and fix the cross-compile problems that are the subject of this ticket. I think I made a little progress but am out of time for today. Probably Georg got further than I did in the past, but I might as well record here what I learned.
Our build is using intl/icu/source/config/mh-mingw, which includes this comment:
# TODO: Finish the rest of this port. This platform port is incomplete.(definitely a bad sign).
In general, there seems to be a mixup in the DLL and import library names. Strange suffixes are certainly used, e.g., .dll.a. I added a couple of config lines to intl/icu/source/config/mh-mingw, which seemed to help:
LIBICUDT=$(top_builddir)/stubdata/$(LIBICU)$(DATA_STUBNAME)$(ICULIBSUFFIX)$(IMPORT_LIB_EXT) LIBICUUC=$(LIBDIR)/$(LIBICU)$(COMMON_STUBNAME)$(ICULIBSUFFIX)$(IMPORT_LIB_EXT) $(LIBICUDT)But now I get the following error:
/home/ubuntu/install/mingw-w64/lib/gcc/i686-w64-mingw32/5.1.0/../../../../i686-w64-mingw32/lib/../lib/libssp.a(ssp.o):ssp.c:(.text+0x239): multiple definition of `__stack_chk_fail' ../lib/icuuc.dll.a(d001684.o):(.text+0x0): first defined here collect2: error: ld returned 1 exit status make[7]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/intl/icu/target/i18n' make[7]: *** [../lib/icuin52.dll] Error 1 make[6]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/intl/icu/target' make[6]: *** [all-recursive] Error 2 make[5]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/config/external/icu' make[5]: *** [buildicu] Error 2 make[4]: *** [config/external/icu/target] Error 2Replying to mcs:
Since adding a simple C++ implementation of the Intl API seems like a big task (please discuss that idea in #16874 (moved)), I spent a little time trying to learn about and fix the cross-compile problems that are the subject of this ticket. I think I made a little progress but am out of time for today. Probably Georg got further than I did in the past, but I might as well record here what I learned.
Our build is using intl/icu/source/config/mh-mingw, which includes this comment:
# TODO: Finish the rest of this port. This platform port is incomplete. }}} (definitely a bad sign). In general, there seems to be a mixup in the DLL and import library names. Strange suffixes are certainly used, e.g., .dll.a. I added a couple of config lines to intl/icu/source/config/mh-mingw, which seemed to help: {{{ LIBICUDT=$(top_builddir)/stubdata/$(LIBICU)$(DATA_STUBNAME)$(ICULIBSUFFIX)$(IMPORT_LIB_EXT) LIBICUUC=$(LIBDIR)/$(LIBICU)$(COMMON_STUBNAME)$(ICULIBSUFFIX)$(IMPORT_LIB_EXT) $(LIBICUDT) }}}There are interesting things going on here. First I tried to tackle this from a different angle: I cross-compiled the ICU lib alone which is surprisingly working out of the box (at least the compilation does not break) and tried to determine what is wrong with Mozilla's one. I took the same version (52.1) and used the same toolchain but I am still puzzled.
I then applied the lines above to a plain ESR 38 build and used the toolchain I built for it. Somehow I am getting quite far. I am probably missing the libssp bits (have not checked yet) but still the build is failing close to the end while linking libxul: {{{ INPUT("../../modules/zlib/src/zutil.o") INPUT("StaticXULComponentsEnd/StaticXULComponentsEnd.o")
i686-w64-mingw32-g++: error: ../../intl/icu/target/lib/libicuin.a: Datei oder Verzeichnis nicht gefunden i686-w64-mingw32-g++: error: ../../intl/icu/target/lib/libicuuc.a: Datei oder Verzeichnis nicht gefunden i686-w64-mingw32-g++: error: ../../intl/icu/target/lib/libicudt.a: Datei oder Verzeichnis nicht gefunden make[5]: *** [xul.dll] Fehler 1
Then I applied the two lines to a gitian build and this failed quite early indicating that both lines are not enough. I am fixing that right now I hope. > But now I get the following error: > {{{ > /home/ubuntu/install/mingw-w64/lib/gcc/i686-w64-mingw32/5.1.0/../../../../i686-w64-mingw32/lib/../lib/libssp.a(ssp.o):ssp.c:(.text+0x239): multiple definition of `__stack_chk_fail' > ../lib/icuuc.dll.a(d001684.o):(.text+0x0): first defined here > collect2: error: ld returned 1 exit status > make[7]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/intl/icu/target/i18n' > make[7]: *** [../lib/icuin52.dll] Error 1 > make[6]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/intl/icu/target' > make[6]: *** [all-recursive] Error 2 > make[5]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/config/external/icu' > make[5]: *** [buildicu] Error 2 > make[4]: *** [config/external/icu/target] Error 2 > }}} Do you have a bit more context? When does this happen?Replying to gk:
Do you have a bit more context? When does this happen?
It happens while building under /home/ubuntu/build/tor-browser/obj-mingw/intl/icu/target/i18n/, while trying to link ../lib/icuin52.dll. I ssh'd into the VM and grabbed the full command:
i686-w64-mingw32-g++ -mwindows -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -Wno-format -fno-exceptions -fno-strict-aliasing -mms-bitfields -mstackrealign -fno-keep-inline-dllexport -frtti -fno-exceptions -fno-math-errno -std=gnu++0x -pipe -g -UDEBUG -DNDEBUG -O -W -Wall -pedantic -Wpointer-arith -Wwrite-strings -Wno-long-long -Wno-unused -Wno-unused-parameter -mthreads -specs=/home/ubuntu/build/msvcr100.spec -static -Wl,--enable-stdcall-fixup -Wl,--large-address-aware -shared -Wl,-Bsymbolic -Wl,--enable-auto-import -Wl,--out-implib=../lib/icuin.dll.a -o ../lib/icuin52.dll ucln_in.o fmtable.o format.o msgfmt.o umsg.o numfmt.o unum.o decimfmt.o dcfmtsym.o ucurr.o digitlst.o fmtable_cnv.o choicfmt.o datefmt.o smpdtfmt.o reldtfmt.o dtfmtsym.o udat.o dtptngen.o udatpg.o nfrs.o nfrule.o nfsubs.o rbnf.o numsys.o unumsys.o ucsdet.o ucal.o calendar.o gregocal.o timezone.o simpletz.o olsontz.o astro.o taiwncal.o buddhcal.o persncal.o islamcal.o japancal.o gregoimp.o hebrwcal.o indiancal.o chnsecal.o cecal.o coptccal.o dangical.o ethpccal.o coleitr.o coll.o tblcoll.o sortkey.o bocsu.o ucoleitr.o ucol.o ucol_res.o ucol_bld.o ucol_sit.o ucol_tok.o ucol_wgt.o ucol_cnt.o ucol_elm.o strmatch.o usearch.o search.o stsearch.o translit.o utrans.o esctrn.o unesctrn.o funcrepl.o strrepl.o tridpars.o cpdtrans.o rbt.o rbt_data.o rbt_pars.o rbt_rule.o rbt_set.o nultrans.o remtrans.o casetrn.o titletrn.o tolowtrn.o toupptrn.o anytrans.o name2uni.o uni2name.o nortrans.o quant.o transreg.o brktrans.o regexcmp.o rematch.o repattrn.o regexst.o regextxt.o regeximp.o uregex.o uregexc.o ulocdata.o measfmt.o currfmt.o curramt.o currunit.o measure.o utmscale.o csdetect.o csmatch.o csr2022.o csrecog.o csrmbcs.o csrsbcs.o csrucode.o csrutf8.o inputext.o wintzimpl.o windtfmt.o winnmfmt.o basictz.o dtrule.o rbtz.o tzrule.o tztrans.o vtzone.o zonemeta.o upluralrules.o plurrule.o plurfmt.o selfmt.o dtitvfmt.o dtitvinf.o udateintervalformat.o tmunit.o tmutamt.o tmutfmt.o currpinf.o uspoof.o uspoof_impl.o uspoof_build.o uspoof_conf.o uspoof_wsconf.o decfmtst.o smpdtfst.o ztrans.o zrule.o vzone.o fphdlimp.o fpositer.o locdspnm.o decNumber.o decContext.o alphaindex.o tznames.o tznames_impl.o tzgnames.o tzfmt.o compactdecimalformat.o gender.o region.o scriptset.o identifier_info.o uregion.o ../lib/icuuc.dll.a ../stubdata/icudt.dll.a -lmAfter a little more poking around this morning, I think the above command should be linking with the DLL (../lib/icuuc52.dll) instead of the static lib (../lib/icuuc.dll.a). I am going to make that change to the lines I suggested adding in comment:5 and see what happens. My revised additions to intl/icu/source/config/mh-mingw are:
# Use correct names for import libraries. # See https://trac.torproject.org/projects/tor/ticket/13419 LIBICUDT= $(top_builddir)/stubdata/$(LIBICU)$(DATA_STUBNAME)$(ICULIBSUFFIX)$(IMPORT_LIB_EXT) LIBICUUC= $(LIBDIR)/$(LIBICU)$(COMMON_STUBNAME)$(ICULIBSUFFIX)$(SO_TARGET_VERSION_MAJOR).$(SO) $(LIBICUDT)And now I get the same error as gk did (when linking xul.dll):
i686-w64-mingw32-g++: error: ../../intl/icu/target/lib/libicuin.a: No such file or directory i686-w64-mingw32-g++: error: ../../intl/icu/target/lib/libicuuc.a: No such file or directory i686-w64-mingw32-g++: error: ../../intl/icu/target/lib/libicudt.a: No such file or directoryThe contents of ../../intl/icu/target/lib are: icudt52.dll icuin52.dll icuin.dll.a icuuc52.dll icuuc.dll.a I am out of time for now, but I guess things are still messed up with respect to import library names, DLL names, etc.
#18767 (moved) shows that the UI of Firefox itself is partly broken now without ICU support. Raising the prio and putting it on the 6.0a5 radar.
Trac:
Reviewer: N/A to N/A
Priority: Medium to High
Keywords: GeorgKoppen201511, TorBrowserTeam201512 deleted, tbb-6.0a5, ff45-esr, TorBrowserTeam201604 added
Sponsor: N/A to N/A
Severity: N/A to MajorMozilla seems to go own ways starting with Firefox 48: https://bugzilla.mozilla.org/show_bug.cgi?id=1239083 I wonder whether we'd need to fix the cross-compilation setup twice now.
Replying to gk:
There are interesting things going on here. First I tried to tackle this from a different angle: I cross-compiled the ICU lib alone which is surprisingly working out of the box (at least the compilation does not break) and tried to determine what is wrong with Mozilla's one. I took the same version (52.1) and used the same toolchain but I am still puzzled.
I thought it might be a good idea to start from here again trying to find out what the issue is. It turns out. ICU does not like the
-staticLDFLAG if it is configured with--disable-static --enable-sharedas it is in a default setup. We have the former requirement due to bug 1116777. The patch in icu.m4 takes care of this.The next issue was that all libraries have the Windows static library suffix
.libwhile.ais expected. This is addressed in the Makefile.in patch.The final problem was that not all libraries are generated with the proper prefix
lib. Changing that in the ICU mingw config and the Makefile.in file solves this.This patch is only meant to get Tor Browser based on ESR45 into shape. Creating upstreamable ones (both to ICU and Mozilla) will be separate tickets. In fact, as I mentioned in my previous comment I guess we'd need a heavily modified one anyway.
Testing a resulting build solves both this bug, #16874 (moved) and #18767 (moved) without noticeable downsides for me.
Please review the attached patch.
Trac:
Status: assigned to needs_review
