Opened 3 years ago

Last modified 19 months ago

#20820 new enhancement

Add font support for Shift-JIS

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-fingerprinting-fonts, tbb-usability-website
Cc: arthuredelstein, gk, yawning, fdsfgs@… Actual Points:
Parent ID: #18097 Points:
Reviewer: Sponsor:

Description

Back with Tor Browser 5, I was able to install monafont on my computer and it would allow Shift-JIS fonts to render properly. Because Tor Browser now uses its own built-in fonts to make fingerprinting of system fonts harder, and because there are no SJIS fonts, I can't correctly view any of it. SJIS is extremely sensitive to spacing, so an alternative font which renders the characters but does not render the spacing correctly does not work at all.

SJIS is used extensively on Japanese websites.

Look at https://ja.wikipedia.org/wiki/モナー (or https://ja.wikipedia.org/wiki/%E3%83%A2%E3%83%8A%E3%83%BC if the browser isn't displaying Japanese. Many Japanese characters do not display at all) and see if the examples it displays in SJIS are anything like the image which it displays on the right.

I have not tested on Windows, only Linux.

Child Tickets

Attachments (2)

IPAMonaPGothic.png (203.6 KB) - added by yawning 3 years ago.
IPA Mona P Gothic (16 pt)
Mona.png (205.7 KB) - added by yawning 3 years ago.
Mona (16 pt)

Download all attachments as: .zip

Change History (12)

comment:1 Changed 3 years ago by gk

Cc: arthuredelstein gk added
Keywords: tbb-fingerprinting-fonts added
Parent ID: #18097

comment:2 Changed 3 years ago by gk

Keywords: tbb-usability-website added

comment:3 Changed 3 years ago by yawning

This should be fine on Windows, the whitelist has MS P Gothic in it IIRC

I'm not sure what the sensible thing to do on Linux is. I don't think we can re-distribute either Mona or IPA Mona with the bundle due to file size reasons. I would also hazard a guess that most Linux systems do not have either installed, so simply whistling them would make the fingerprinting situation worse.

Changed 3 years ago by yawning

Attachment: IPAMonaPGothic.png added

IPA Mona P Gothic (16 pt)

Changed 3 years ago by yawning

Attachment: Mona.png added

Mona (16 pt)

comment:4 Changed 3 years ago by yawning

Per discussion on IRC, we may end up shipping one of these instead of NotoSansJP-Regular.otf.

The IPA Mona licensing looks kind of convoluted, so the Mona is probably easier/simpler to ship.

comment:5 Changed 3 years ago by yawning

As a side note, even with the "correct" font(s), all the art under the モナーの進化 header looks messed up. I don't have a windows system to check if that's a Wikipedia issue or a font issue, though I suspect it's the former.

comment:6 in reply to:  5 ; Changed 2 years ago by cypherpunks

Replying to yawning:

As a side note, even with the "correct" font(s), all the art under the モナーの進化 header looks messed up. I don't have a windows system to check if that's a Wikipedia issue or a font issue, though I suspect it's the former.

I tested on Windows 7 with Tor Browser 6.0.8, and it seems to display correctly. It does not on Linux.

Version 0, edited 2 years ago by cypherpunks (next)

comment:7 in reply to:  6 Changed 2 years ago by yawning

Cc: yawning added

Replying to cypherpunks:

Replying to yawning:

As a side note, even with the "correct" font(s), all the art under the モナーの進化 header looks messed up. I don't have a windows system to check if that's a Wikipedia issue or a font issue, though I suspect it's the former.

I tested on Windows 7 with Tor Browser 6.0.8, and it seems to display correctly. It does not on Linux.

I've been testing with standard firefox instead of Tor Browser since I didn't feel like messing with the whitelist config. A quick check shows that the art under that subheading is broken even in chromium. So not sure what to say.

An even better test of SJIS, btw, is プロポーショナルフォントのもの and down.

Those display fine with Mona and IPAMonaPGothic, so I think the plan of "Ship Mona instead of NotoSans as the Japanese font" would be enough of an improvement.

comment:8 Changed 2 years ago by tokotoko

Cc: fdsfgs@… added

comment:9 Changed 19 months ago by cypherpunks

Those display fine with Mona and IPAMonaPGothic, so I think the plan of "Ship Mona instead of NotoSans as the Japanese font" would be enough of an improvement.

Is there anything preventing this from going forward?

comment:10 in reply to:  9 Changed 19 months ago by gk

Replying to cypherpunks:

Those display fine with Mona and IPAMonaPGothic, so I think the plan of "Ship Mona instead of NotoSans as the Japanese font" would be enough of an improvement.

Is there anything preventing this from going forward?

Yes. We need someone to come up with a patch we can review, merge and deploy.

Note: See TracTickets for help on using tickets.