Opened 4 years ago

Closed 4 years ago

#20826 closed defect (implemented)

Restrict GUARDS set to EntryNodes when the set of guards is restrictive

Reported by: nickm Owned by: nickm
Priority: Very High Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-guard regression TorCoreTeam201612
Cc: asn Actual Points: .1
Parent ID: #20822 Points: 2
Reviewer: Sponsor:


In proposal 271, I suggested that when EntryNodes is a very restrictive set, we should use it, rather than GUARDS, to build our sample.

We already support having a separate guard selection here in the new guard code (see #19888), but we don't restrict the GUARDS input set in the way I had suggested yet.

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by dgoulet

Keywords: tor-guard added

comment:2 Changed 4 years ago by nickm

Keywords: regression added
Owner: set to nickm
Priority: MediumVery High
Status: newaccepted

comment:3 Changed 4 years ago by nickm

Keywords: TorCoreTeam201612 added
Points: 2

comment:4 Changed 4 years ago by nickm

Actual Points: .1
Cc: asn added
Status: acceptedneeds_review

This was way, way easier than I had expected.

Implementation in ticket20826, on top of prop271_030_v1.

comment:5 Changed 4 years ago by asn

Kind of a kludgy fix but I can see why it works! I wonder how we could do this more cleanly instead of special-casing restricted mode in that function.

If no obvious better way, perhaps we can add a bit of motivation on the new comment?

comment:6 Changed 4 years ago by nickm

I've added a bit of a comment to the branch.

comment:7 Changed 4 years ago by asn

Status: needs_reviewmerge_ready

new comment lgtm. i think we can proceed with this.

comment:8 Changed 4 years ago by nickm

Rebased and squashed as ticket20826_v2

comment:9 Changed 4 years ago by nickm

Resolution: implemented
Status: merge_readyclosed


Note: See TracTickets for help on using tickets.