Opened 9 years ago

Closed 9 years ago

#2083 closed enhancement (implemented)

Allow configuration of all torrc options via Vidalia

Reported by: chiiph Owned by:
Priority: Medium Milestone:
Component: Archived/Vidalia Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is a reference to https://trac.vidalia-project.net/ticket/76

Attached is a patch to give Vidalia basic torrc "online" editing and saving. The details of how it's done can be found in the documentation of the code itself.

Regarding phobos commentary:
"I had a thought about fixing this. What if we created a _vidalia user and _vidalia group? The bundle could then see if Tor is already installed, and change /Library/Tor/torrc to chown root:_vidalia with chmod 664 permissions. This way vidalia gui client can write to the config file."

This can be possible if the user running Vidalia also belongs to the Vidalia group, just like packages like lighttpd run in Gentoo. And this way Tor can be used as a regular service in Linux.
I guess this is more on the package maintainer side, than on the development side.

Anyway, I'd really appreciate comments and critics on this patch.

Child Tickets

Attachments (2)

vidalia-torrc.patch (25.5 KB) - added by chiiph 9 years ago.
Patch for basic torrc editing in Vidalia
vidalia-torrc-r1.patch (26.0 KB) - added by chiiph 9 years ago.
Here's a new patch for the same feature, changing some of the options isn't possible while Tor is running, so I added a checkbox to decide whether to save or not the file but try to apply the settings anyway, this way it works like an advance configuration editor more than a torrc editor.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by chiiph

Attachment: vidalia-torrc.patch added

Patch for basic torrc editing in Vidalia

comment:1 in reply to:  description ; Changed 9 years ago by Sebastian

Replying to chiiph:

Regarding phobos commentary:
"I had a thought about fixing this. What if we created a _vidalia user and _vidalia group? The bundle could then see if Tor is already installed, and change /Library/Tor/torrc to chown root:_vidalia with chmod 664 permissions. This way vidalia gui client can write to the config file."

This can be possible if the user running Vidalia also belongs to the Vidalia group, just like packages like lighttpd run in Gentoo. And this way Tor can be used as a regular service in Linux.
I guess this is more on the package maintainer side, than on the development side.

I believe this to be outdated. On OS X, Vidalia now always runs as the user that started it and we don't create any system users anymore.

comment:2 in reply to:  1 ; Changed 9 years ago by chiiph

Replying to Sebastian:

I believe this to be outdated. On OS X, Vidalia now always runs as the user that started it and we don't create any system users anymore.

I don't have any experience on OS X, but on Linux I think this can be a really good chance to integrate everything. Currently Tor service runs as root, and it conflicts with Vidalia when it runs as a normal user. Unifying this with a common user/group can be a nice solution, but again, it's more a matter of what every distribution decides rather than what's decided here.
On the other hand, for Windows and OS X, where the idea of "bundled" is a good thing, this doesn't really matter.

comment:3 in reply to:  2 Changed 9 years ago by rransom

Replying to chiiph:

I don't have any experience on OS X, but on Linux I think this can be a really good chance to integrate everything. Currently Tor service runs as root,

When Tor is run as a system service, it is usually started by root, but configured to switch to a dedicated tor user account, in a dedicated tor group.

and it conflicts with Vidalia when it runs as a normal user.

I used CookieAuthFileGroupReadable to attach Vidalia to a system-wide Tor instance. This can (and should) be set up by the Tor packager.

Changed 9 years ago by chiiph

Attachment: vidalia-torrc-r1.patch added

Here's a new patch for the same feature, changing some of the options isn't possible while Tor is running, so I added a checkbox to decide whether to save or not the file but try to apply the settings anyway, this way it works like an advance configuration editor more than a torrc editor.

comment:4 Changed 9 years ago by chiiph

Resolution: implemented
Status: newclosed

This is now committed to Vidalia's svn.

Note: See TracTickets for help on using tickets.