Opened 6 months ago

Closed 6 months ago

#20839 closed defect (fixed)

Stop rejecting NS descriptors when microdescs are the default

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.2.3.2-alpha
Severity: Normal Keywords: review-group-13
Cc: Actual Points: 0.2
Parent ID: #20667 Points: 0.2
Reviewer: nickm Sponsor:

Description

When we merged #6769, it exposed a bug in router_get_routerlist(), which checks full router descriptors against the usable consensus flavour. This check fails for all downloaded descriptors when the usable flavour is microdescriptor.

Directory servers were somewhat immune to this issue, because they still put the descriptors that failed this check in old_routers. But this still might have caused subtle bugs down the track.

Child Tickets

Change History (6)

comment:1 Changed 6 months ago by teor

  • Parent ID set to #20667
  • Status changed from new to needs_review

This is fixed in my github branch bug20667

comment:2 Changed 6 months ago by teor

(So let's track and review it in #20667.)

comment:3 Changed 6 months ago by teor

This bug could cause authorities and mirrors to consider all descriptors old or failed. And it might also cause issues with caching them, working out when to discard them as old, and serving them over either the control port or DirPort.

comment:4 Changed 6 months ago by nickm

  • Keywords review-group-13 added

comment:5 Changed 6 months ago by nickm

  • Reviewer set to nickm

comment:6 Changed 6 months ago by nickm

  • Resolution set to fixed
  • Status changed from needs_review to closed

Merged parent.

Note: See TracTickets for help on using tickets.