#20851 closed defect (fixed)

If the incremental update fails, fall back to the complete update.

Reported by: yawning Owned by: yawning
Priority: High Milestone:
Component: Archived/Tor Browser Sandbox Version:
Severity: Normal Keywords: Yawning201612, sandbox-update
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Right now there is no code for falling back to the complete update if the incremental one fails. There needs to be code to handle this situation since the updater failing isn't unheard of.

Child Tickets

Change History (6)

comment:1 Changed 21 months ago by mcs

Cc: brade mcs added

comment:2 Changed 20 months ago by yawning

Priority: MediumHigh

Bump up the priority on things I think are important for 0.0.2.

comment:3 Changed 20 months ago by yawning

Keywords: Yawning201612 added
Status: newaccepted

Tagging these as the things I will be focusing on for the rest of the year.

comment:4 Changed 20 months ago by yawning

I have this working (as in tested) as part of my work in progress, not uploaded yet #20778 branch.

~The one shortcoming to the new code as is, would be that if the user fails the partial update, and cancels the complete update, when they come back later, it will re-attempt the incremental update, wasting a bit of time and bandwidth. I guess I can add a flag or something to force the complete update...~

Edit: I fixed the issue with re-downloading a partial update that will never succeed.

Last edited 20 months ago by yawning (previous) (diff)

comment:5 Changed 20 months ago by yawning

Keywords: sandbox-update added
Note: See TracTickets for help on using tickets.