Opened 3 years ago

Closed 3 years ago

#20863 closed defect (fixed)

Unittest fail on master: FAIL src/test/test_controller.c:190: assert(!cfg)

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

On latest master (e6facbfe7abc50de374300ecd83873ead65b4b04) the following test fails on my box:

control/rend_service_parse_port_config: 
  FAIL src/test/test_controller.c:190: assert(!cfg)
  [rend_service_parse_port_config FAILED]

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by nickm

Of interest: This doesn't happen for me, but asn said that he was on a train when he was running the tests. This is probably something to do with the train's messed-up network...

comment:2 Changed 3 years ago by teor

Yes, there are definitely unit tests that depend on the network being either up or down, and not something in-between. (When my network is off, the unit tests complete in about a second. When it's up, they complete in about 10 seconds.)

comment:3 Changed 3 years ago by asn

Can confirm that now that I'm back in stable internet those tests complete successfuly and super fast. When I was in a flaky connection, those tests were failing in a reproducible way.

comment:4 Changed 3 years ago by nickm

I still say it's worth fixing this if we can.

comment:5 Changed 3 years ago by teor

We should mock the resolver? functions being called here.

comment:6 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-finalTor: 0.3.0.x-final

comment:7 Changed 3 years ago by nickm

The case it's actually testing is

  cfg = rend_service_parse_port_config("100 1.2.3.4.5:9000",
                                       " ", &err_msg);
  tt_assert(!cfg);
  tt_str_op(err_msg, OP_EQ, "Unparseable address in hidden service port "
            "configuration.");
  tor_free(err_msg);

comment:8 Changed 3 years ago by nickm

Status: newneeds_review

Fixed as part of my bug20862 branch; see #20862.

comment:9 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged!

Note: See TracTickets for help on using tickets.