Opened 3 years ago

Closed 3 years ago

#20864 closed defect (fixed)

Minor fixes to test_single_onion_poisoning

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: hs, 029-backport
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

When I wrote #20638, the unit test had some subtle bugs:

  • a missed return value check in a unit test,
  • a double-free (well, two double-frees),
  • an inconsistent allocation-free construction that would be easy to break in future.

I also want to move a comment.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by teor

Keywords: 029-backport added
Status: newneeds_review

Please see my github branch bug20864-029.

comment:2 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged, with an edit to the changes file. Thank you! Sorry for the double-free.

Note: See TracTickets for help on using tickets.