Tor 0.2.8.10 breaks compilation on macOS Sierra

We forgot to backport the sys/random.h header include and its check. This means that tor 0.2.8.10 compiles on pre-sierra systems, but not on sierra itself.

changed milestone to %Tor: 0.2.8.x-final

added component::core tor/tor macos milestone::Tor: 0.2.8.x-final points::0.1 priority::high regression resolution::fixed severity::major status::closed type::defect version::tor 0.2.8.10 labels

Hm. For 0.2.8, I think I would rather not backport, but instead do

#ifdef __APPLE__
#undef HAVE_GETENTROPY
#endif

Works for me. Edit: that solution seems like a good one to me.

714aeedc5278fe50fb2b9ccafeefa4270eaf3391 is the fix, tested, with a changes file and some comments.

Trac:
Resolution: N/A to fixed
Status: new to closed

closed

changed time estimate to 48m

moved to tpo/core/tor#20865 (closed)