DIRCACHE_MIN_MEM_MB does not stringify on FreeBSD, we should use %d instead

A FreeBSD relay operator reports the message:

[WARN] Being a directory cache (default) with less than DIRCACHE_MIN_MB_BANDWIDTH MB of memory is not recommended and may consume most of the available resources, consider disabling this functionality by setting the DirCache option to 0

So we should print the macro value the same way we do every other value, using "%d" in the string, and passing it as an argument.

(This macro changed name in #20684 (moved).)

changed milestone to %Tor: 0.3.4.x-final

added component::core tor/tor easy logging milestone::Tor: 0.3.4.x-final priority::medium refactor resolution::fixed severity::normal status::closed tor-relay type::defect version::tor 0.2.8.1-alpha labels

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Keywords: easy intro refactor deleted, tor-03-unspecified-201612, intro, refactor, easy added
Milestone: Tor: 0.3.??? to Tor: unspecified

Trac:
Summary: DIRCACHE_MIN_MB_BANDWIDTH does not stringify on FreeBSD, we should use %d instead to DIRCACHE_MIN_MEM_MB does not stringify on FreeBSD, we should use %d instead
Description: A FreeBSD relay operator reports the message:

[WARN] Being a directory cache (default) with less than DIRCACHE_MIN_MB_BANDWIDTH MB of memory is not recommended and may consume most of the available resources, consider disabling this functionality by setting the DirCache option to 0

So we should print the macro value the same way we do every other value, using "%d" in the string, and passing it as an argument.

This macro will change name in #20684 (moved).

to

A FreeBSD relay operator reports the message:

[WARN] Being a directory cache (default) with less than DIRCACHE_MIN_MB_BANDWIDTH MB of memory is not recommended and may consume most of the available resources, consider disabling this functionality by setting the DirCache option to 0

So we should print the macro value the same way we do every other value, using "%d" in the string, and passing it as an argument.

(This macro changed name in #20684 (moved).)

Agreed. Also, since we'll be using an arg, we want to use tor_asprintf() rather than tor_strdup().

This one's easy! Any new developers want to grab it?

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: intro deleted, tor-relay, logging added

Trac:
Cc: N/A to neel@neelc.org

Trac:
b20887-p1.patch

[PATCH] Change to tor_asprintf for DIRCACHE_MIN_MB_BANDWIDTH in have_enough_mem_for_dircache() (Revision 1)

I have a patch under the filename b20887-p1.patch​.

Looks fine to me

Trac:
Status: new to merge_ready

There's a problem with this patch -- it removes the blank spaces before the quotation marks at the end of some of the lines. Without those blank spaces, there will not be appropriate spacing between words in the log message.

For example, this code

     tor_asprintf(msg, "Being a directory cache (default) with less than"
 		       "%d MB of memory is not recommended and may consume"
 		       "most of the available resources, consider disabling "
 		       "this functionality by setting the DirCache option "
 		       "to 0.", DIRCACHE_MIN_MEM_MB);

will produce a log message beginning with:

Being a directory cache (default) with less than300 MB of memory is not recommended and may consumemost of the available resources...

Note the "than300" and "consumemost" problem.

Also, while we're changing this, let's replace the comma before "consider" with a period: those are two separate sentences.

Trac:
Status: merge_ready to needs_revision
Milestone: Tor: unspecified to Tor: 0.3.4.x-final

Trac:
b20887-p2.patch

[PATCH] Change to tor_asprintf for DIRCACHE_MIN_MB_BANDWIDTH in have_enough_mem_for_dircache() (Revision 1)

Replying to nickm:

There's a problem with this patch -- it removes the blank spaces before the quotation marks at the end of some of the lines. Without those blank spaces, there will not be appropriate spacing between words in the log message.

For example, this code {{{ tor_asprintf(msg, "Being a directory cache (default) with less than" "%d MB of memory is not recommended and may consume" "most of the available resources, consider disabling " "this functionality by setting the DirCache option " "to 0.", DIRCACHE_MIN_MEM_MB); }}} will produce a log message beginning with:

Being a directory cache (default) with less than300 MB of memory is not recommended and may consumemost of the available resources...

Note the "than300" and "consumemost" problem.

Also, while we're changing this, let's replace the comma before "consider" with a period: those are two separate sentences.

I made the changes in the patch b20887-p2.patch.

lgtm; thanks for the fast turnaround! Merging to master.

merged to master as bc5f79b95c5f809635bc84dbdd3010350bfbc269 with a tweak to the changes file so make check would pass.

Trac:
Resolution: N/A to fixed
Status: needs_revision to closed

closed

moved to tpo/core/tor#20887 (closed)