Opened 3 years ago

Closed 3 years ago

#20903 closed defect (fixed)

gitian-builder branch is not getting updated in nightly builds

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian, TorBrowserTeam201612R
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It seems we are missing a git pull in case we are updating gitian-builder for nightly builds. Despite having new commits available the branch gets not fast forwarded.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by gk

Keywords: TorBrowserTeam201612R added
Status: newneeds_review

comment:2 Changed 3 years ago by boklm

This looks good.

As an alternative, we could just change GITIAN_TAG to origin/tor-browser-builder-4 (instead of tor-browser-builder-4) in gitian/versions.nightly, so that a pull is not needed.

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. That's true but I'd like to avoid special casing gitian-builder here even more (although it kind of is already). I took the patch and applied it to master and hardened-buidls (commit ff22f6b3c8662a6bfcd67c17f86a4ca98564099c and a0c4b74b735e2e2c71bfe9054cde5085ca9033c7).

Note: See TracTickets for help on using tickets.