Extract prop271 state-parsing code into a generic thing

changed milestone to %Tor: unspecified

added component::core tor/tor configuration milestone::Tor: unspecified parent::20822 points::3 priority::medium severity::normal status::new technical-debt torrc type::defect labels

Triaged out on December 2016 from 030 to 031.

Trac:
Milestone: Tor: 0.3.0.x-final to Tor: 0.3.1.x-final
Keywords: N/A deleted, triage-out-030-201612 added

The goal of this ticket would be to refactor entry_guard_parse_from_state() (and family) to use the config/state parsing API, instead of the ad-hoc string parsing approach it currently uses.

As an example, see entry_guards_parse_state_for_guard_selection() and how it uses the config_line_t API. Is it more elegant?

Is it more elegant?

IMO it isn't. It requires separate config_lines for anything, requires a loop over all the lines, and is harder to read as a function.

We have lots of places throughout our code that use a space-separated K=V metaformat, like FooPort lines and so on. It could be cool to refactor all of those, and this, to use a common parser.

Trac:
Milestone: Tor: 0.3.1.x-final to Tor: unspecified
Points: N/A to 3

Trac:
Keywords: triage-out-030-201612 deleted, N/A added

Trac:
Keywords: N/A deleted, torrc configuration technical-debt added

changed time estimate to 24h

moved to tpo/core/tor#20919 (closed)