Opened 3 years ago

Closed 3 years ago

#20920 closed defect (implemented)

Lower MAX_SAMPLE_THRESHOLD by a lot

Reported by: nickm Owned by: nickm
Priority: High Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: asn, chelseakomlo Actual Points:
Parent ID: #19877 Points:
Reviewer: Sponsor:

Description

the current value of 0.3.0 in my prop271_030_v1 branch is ridiculously large.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 3 years ago by nickm

Cc: asn chelseakomlo added
Status: acceptedneeds_review

In 45889fafbd7d7e747793f6e26074abf24b85352e, I've added a fix for this to my prop271_030_v1 branch.

Last edited 3 years ago by nickm (previous) (diff)

comment:3 Changed 3 years ago by nickm

a5a4640a9544d2 in my torspec prop271-changes branch specifies the change.

comment:4 Changed 3 years ago by asn

I wonder if the fractional restriction is any useful now that we have the absolute restriction. In most cases the absolute restriction will take priority over fractional restriction (20% of total guards is like 110 guards right now).

I feel like the absolute restriction is more accurate and powerful. Maybe we can kill the fractional one to reduce code?

Perhaps it would make sense to introduce the fractional restriction if it was based on guard bandwidth and not just number of guards.

comment:5 Changed 3 years ago by nickm

Maybe. I'm thinking that there are network sizes where the fractional restriction matters more -- like on a 30-node network, for instance. At least, that's what I had in mind.

comment:6 Changed 3 years ago by asn

Hmm I can see how that makes sense. However, if we are trying to provide security for such tiny networks (30 nodes) we would probably have to change the rest of our guard picking strategy quite a bit as well.

Anyhow, no strong opinions here and the code seems reasonable.

comment:7 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.