Bump GCC version in our alpha builds

For the 7.0aX series we should bump the GCC version used to the latest stable in the 5.x series. The hardened builds are already done with GCC 5.4.0, thus there is no reason to use a different GCC (currently 5.1.0) in the alphas.

added GeorgKoppen201707 TorBrowserTeam201707R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-gitian type::enhancement labels

bug_20929 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20929&id=edc35ff67352d66390c1cce94b4a2f114dd91a2e) in my tor-browser-bundle repo has a fix for review.

Trac:
Keywords: TorBrowserTeam201701 deleted, TorBrowserTeam201701R added
Status: new to needs_review

r=brade r=mcs

This looks okay.

Turns out we are already hitting https://bugzilla.mozilla.org/show_bug.cgi?id=1305396 with the bump to 5.4.0. Thus we need to have a fix for that one first as well.

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201701R deleted, TorBrowserTeam201701 added

Trac:
Status: needs_revision to assigned

Trac:
Keywords: TorBrowserTeam201701 deleted, TorBrowserTeam201707, GeorgKoppen201707 added

Not sure if I did everything right but here comes my first review request via oniongit. https://oniongit.eu/gk/tor-browser-bundle/merge_requests/1

Trac:
Keywords: TorBrowserTeam201707 deleted, TorBrowserTeam201707R added
Status: assigned to needs_review

FWIW https://bugzilla.mozilla.org/show_bug.cgi?id=1305396 is a non-issue anymore after we switched to esr52. Not sure which change fixed it, though.

Replying to gk:

Not sure if I did everything right but here comes my first review request via oniongit. https://oniongit.eu/gk/tor-browser-bundle/merge_requests/1 "You need to sign in or sign up before continuing." :(

Replying to cypherpunks:

Replying to gk:

Not sure if I did everything right but here comes my first review request via oniongit. https://oniongit.eu/gk/tor-browser-bundle/merge_requests/1 "You need to sign in or sign up before continuing." :(

Seems to have been a misconfiguration on my side. It should work now.

Replying to gk:

Seems to have been a misconfiguration on my side. It should work now. Yep. There is a GCC 5.5 Release (Pending) with about 220 fixes, or https://gcc.gnu.org/ml/gcc/2017-07/msg00074.html, if you don't want to wait.

Replying to gk:

Not sure if I did everything right but here comes my first review request via oniongit. https://oniongit.eu/gk/tor-browser-bundle/merge_requests/1

This change looks good.

I tried doing a build with rbm and this gcc version and it built without error.

Corresponding changes in tor-browser-build.git: https://oniongit.eu/boklm/tor-browser-build/merge_requests/1

Thanks. Applied to master (tor-browser-bundle) with commit f890b38fd0ffc2572edc0e4dafc8a3aa3d16faa0 and to master (tor-browser-build) with commit 51ed356d2d4d411b7566987a7cc63d61c0ecd9d4.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#20929 (closed)