Opened 11 months ago

Closed 3 months ago

#20929 closed enhancement (fixed)

Bump GCC version in our alpha builds

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian, TorBrowserTeam201707R, GeorgKoppen201707
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For the 7.0aX series we should bump the GCC version used to the latest stable in the 5.x series. The hardened builds are already done with GCC 5.4.0, thus there is no reason to use a different GCC (currently 5.1.0) in the alphas.

Child Tickets

Change History (12)

comment:1 Changed 9 months ago by gk

Keywords: TorBrowserTeam201701R added; TorBrowserTeam201701 removed
Status: newneeds_review

comment:2 Changed 9 months ago by mcs

r=brade
r=mcs

This looks okay.

comment:3 Changed 9 months ago by gk

Keywords: TorBrowserTeam201701 added; TorBrowserTeam201701R removed
Status: needs_reviewneeds_revision

Turns out we are already hitting https://bugzilla.mozilla.org/show_bug.cgi?id=1305396 with the bump to 5.4.0. Thus we need to have a fix for that one first as well.

comment:4 Changed 9 months ago by gk

Status: needs_revisionassigned

comment:5 Changed 4 months ago by gk

Keywords: TorBrowserTeam201707 GeorgKoppen201707 added; TorBrowserTeam201701 removed

comment:6 Changed 3 months ago by gk

Keywords: TorBrowserTeam201707R added; TorBrowserTeam201707 removed
Status: assignedneeds_review

Not sure if I did everything right but here comes my first review request via oniongit. https://oniongit.eu/gk/tor-browser-bundle/merge_requests/1

comment:7 Changed 3 months ago by gk

FWIW https://bugzilla.mozilla.org/show_bug.cgi?id=1305396 is a non-issue anymore after we switched to esr52. Not sure which change fixed it, though.

comment:8 in reply to:  6 ; Changed 3 months ago by cypherpunks

Replying to gk:

Not sure if I did everything right but here comes my first review request via oniongit. https://oniongit.eu/gk/tor-browser-bundle/merge_requests/1

"You need to sign in or sign up before continuing."
:(

comment:9 in reply to:  8 ; Changed 3 months ago by gk

Replying to cypherpunks:

Replying to gk:

Not sure if I did everything right but here comes my first review request via oniongit. https://oniongit.eu/gk/tor-browser-bundle/merge_requests/1

"You need to sign in or sign up before continuing."
:(

Seems to have been a misconfiguration on my side. It should work now.

comment:10 in reply to:  9 Changed 3 months ago by cypherpunks

Replying to gk:

Seems to have been a misconfiguration on my side. It should work now.

Yep.
There is a GCC 5.5 Release (Pending) with about 220 fixes, or https://gcc.gnu.org/ml/gcc/2017-07/msg00074.html, if you don't want to wait.

comment:11 in reply to:  6 Changed 3 months ago by boklm

Replying to gk:

Not sure if I did everything right but here comes my first review request via oniongit. https://oniongit.eu/gk/tor-browser-bundle/merge_requests/1

This change looks good.

I tried doing a build with rbm and this gcc version and it built without error.

Corresponding changes in tor-browser-build.git: https://oniongit.eu/boklm/tor-browser-build/merge_requests/1

comment:12 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Applied to master (tor-browser-bundle) with commit f890b38fd0ffc2572edc0e4dafc8a3aa3d16faa0 and to master (tor-browser-build) with commit 51ed356d2d4d411b7566987a7cc63d61c0ecd9d4.

Note: See TracTickets for help on using tickets.