Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20935 closed defect (fixed)

Typo in macOS Sierra macro in configure

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.10
Severity: Normal Keywords: typo
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

sbs reports that there is a typo in the MAC_OS_VERSION_10_12 macro in:
https://gitweb.torproject.org/tor.git/tree/configure.ac#n433
(It's missing an 'X_'.)

This has no impact, because we define MAC_OS_VERSION_10_12 if it's not defined (which it never is).

This was introduced in commit 16fcbd21 in tor-0.2.8.10.

Reported by Simone Basso, please credit in changes file.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

So it should be MAC_OSX_VERSION_10_12?

comment:2 Changed 3 years ago by teor

Oops, no, MAC_OS_X_VERSION_10_12.
My 'X_' was wrong.

Please just copy it from AvailabilityMacros.h!

comment:3 Changed 3 years ago by nickm

I might be going crazy, but none of the 4 copies of AvailabilityMacros.h on my sierra box actually have a 10_12; they all stop at MAC_OS_X_VERSION_10_11_4. Do you have one?

comment:4 Changed 3 years ago by teor

I have Sierra 10.12.1.

From /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/AvailabilityMacros.h

#define MAC_OS_X_VERSION_10_12      101200
#define MAC_OS_X_VERSION_10_12_1    101201

You'll want MAC_OS_X_VERSION_10_12.

(If they left it out in the original 10.12 release, that could explain why the functions weren't tagged. Or maybe you need an updated Xcode? I have 8.1. Or an updated Xcode developer tools install?)

comment:5 Changed 3 years ago by nickm

Status: acceptedneeds_review

bug20935_029 in my public repository has an attempt!

comment:6 Changed 3 years ago by teor

Status: needs_reviewmerge_ready

Looks good to me. All the X's seem to be in the right place.
(It seems to me that the macOS re-branding has not reached the Cupertino dev teams yet, or perhaps they prefer consistency over marketing.)

comment:7 Changed 3 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

ok, merged!

comment:8 Changed 3 years ago by nickm

(They also have MAC_10_12, but I think that's off-brand as well)

Version 0, edited 3 years ago by nickm (next)
Note: See TracTickets for help on using tickets.