Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20947 closed defect (fixed)

Increase max 2016 donation banner views to 50

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201612R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We want to increase the maximum donation banner views to give users a chance to donate in December.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201612R added
Status: newneeds_review

Here is a patch for review:

https://github.com/arthuredelstein/torbutton/commit/20947

(I also modified the donate button code a little to improve its appearance. And I changed the US English text to "Please Donate!")

Last edited 3 years ago by arthuredelstein (previous) (diff)

comment:2 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Alright, this got merged to master and maint-1.9.5 (commit 745bb08cc685848469c7ac55a2575bbefa674a2f and 0f89bd00a61b398e4a3c6e6a9894a1af0104d87e). We are currently rebundling 6.0.8 to include the fix.

comment:3 Changed 3 years ago by arthuredelstein

To confirm: I tested these changes on Mac, Linux, and Windows for all locales and it looked OK.

Note: See TracTickets for help on using tickets.