Opened 3 years ago

Closed 3 years ago

#20966 closed task (implemented)

Parts of deployed shared random protocol are specified only in the proposal

Reported by: arma Owned by: asn
Priority: High Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, tor-sr
Cc: teor Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor: SponsorR

Description

In dir-spec.txt, commit c4ae4dd31 gave us lines like

+        Denotes a directory authority commit for the shared randomness
+        protocol, containing the commitment value and potentially also the
+        reveal value. See sections [COMMITREVEAL] and [VALIDATEVALUES] of
+        proposal 250 on how to generate and validate these values.

That's a great improvement over just leaving it implicit. But if we have a goal of having Tor specified in the spec files (is that true?), then we should migrate the key sections from the proposal file to either dir-spec or a new srv-spec file.

Child Tickets

Change History (14)

comment:1 Changed 3 years ago by nickm

Cc: asn teor added
Keywords: spec added; SponsoR removed
Milestone: Tor: 0.3.0.x-final
Priority: MediumHigh
Sponsor: SponsorR
Type: defectenhancement

comment:2 Changed 3 years ago by teor

I think a srv-spec might be a good idea, and we can reference it from the main dir-spec.
(dir-spec is getting pretty big and hard to search.)

comment:3 Changed 3 years ago by dgoulet

I'm also on the side of making a new document out of the full proposal and refering it. Our dir-spec.txt and tor-spec.txt in particular are getting so big that breaking it down would be a good idea imo.

If we agree, I can work on a patch to create srv-spec.txt.

comment:4 Changed 3 years ago by dgoulet

Keywords: tor-sr added

comment:5 Changed 3 years ago by dgoulet

Owner: set to dgoulet
Status: newaccepted

comment:6 Changed 3 years ago by nickm

Points: .5

comment:7 Changed 3 years ago by dgoulet

Status: acceptedneeds_information

comment:8 Changed 3 years ago by nickm

Status: needs_informationassigned

we agree; I think this should be assigned? The dir-spec.txt does need some changes, since this does affect what goes into the directory.

comment:9 Changed 3 years ago by nickm

Type: enhancementtask

comment:10 Changed 3 years ago by asn

+1 for srv-spec.txt as well. David, I can try to do this at some point soon if you'd like me to.

comment:11 in reply to:  10 Changed 3 years ago by dgoulet

Cc: asn removed
Keywords: tor-spec added; spec removed
Owner: changed from dgoulet to asn
Points: .50.5

Replying to asn:

+1 for srv-spec.txt as well. David, I can try to do this at some point soon if you'd like me to.

Ok I'll let you go crazy with that! Thanks!

comment:12 Changed 3 years ago by asn

Status: assignedneeds_review

Hello people. Please check my torspec branch bug20966 for a fix here.
Let me know if you like it and I can merge it.

comment:13 Changed 3 years ago by dgoulet

Status: needs_reviewmerge_ready

Like it! lgtm;

comment:14 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged it!

Note: See TracTickets for help on using tickets.