Call no directory guard happy until its directory headers are received

In my prop271 code as it is, we call entry_guard_succeeded() from connection_dir_process_inbuf(). But apparently that can get called without data actually having been read. We should instead call the guard successful only when we get good-looking headers from it.

changed milestone to %Tor: 0.3.0.x-final

added actualpoints::.1 component::core tor/tor milestone::Tor: 0.3.0.x-final owner::nickm parent::20822 points::.5 priority::medium resolution::fixed severity::normal status::closed type::defect labels

If we are going to make this change, maybe we should make it in the bootstrapping code, too? It calls a hard-coded directory connection successful when it connects. But maybe we want to wait until we start receiving sensible info from it? (This could be a separate but related ticket.)

I think that would be good idea; but let's make a separate ticket for it?

Trac:
Status: new to assigned
Owner: N/A to nickm

Trac:
Points: N/A to .5

My branch bug20974 seems possible here.

Trac:
Status: assigned to needs_review

Trac:
Actualpoints: N/A to .1

lgtm; I'm unsure how to test this but the change seems reasonable. make test is happy.

Trac:
Status: needs_review to merge_ready

I can verify that this fix works, as Tor used to mark many guards as successful just because we reached connection_dir_process_inbuf() (which apparently can happen when the socket closes).

The new code does not seem to false-positive mark guards as up. merge_ready from me as well.

I'll be monitoring the new code.

Merging this. Thanks for looking at it!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

changed time estimate to 4h

added 48m of time spent

moved to tpo/core/tor#20974 (closed)