Opened 3 years ago

Closed 3 years ago

#20992 closed enhancement (implemented)

hs: Add more unit tests for failure cases of parsing and validation for ESTABLISH_INTRO v3 cells

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224, test
Cc: Actual Points:
Parent ID: #17241 Points: 0.4
Reviewer: asn Sponsor: SponsorR-must

Description

For instance: bad sig_len, bad auth_key_len, bad MAC, and bad signature.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by dgoulet

Owner: set to dgoulet
Status: newaccepted

comment:2 Changed 3 years ago by dgoulet

Status: acceptedneeds_review

See branch bug20992_030_01.

comment:3 Changed 3 years ago by dgoulet

Parent ID: #17241
Reviewer: #17241

Always better when the parent ID ticket is actually in that field ;).

comment:4 Changed 3 years ago by asn

Reviewer: asn

comment:5 Changed 3 years ago by asn

Status: needs_reviewmerge_ready

LGTM. Tests seem to pass as well. Thanks for the code!

comment:6 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged, wide lines fixed.

Note: See TracTickets for help on using tickets.