Opened 4 years ago

Last modified 3 years ago

#21023 new defect

Replace custom checks with Autoconf macros

Reported by: cypherpunks Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: autotools build technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Removing environ in #19142 didn't work on BSDs but the check in can be simplified. Autoconf provides the AC_CHECK_DECL macro for these kinds of checks and turns the current check into a oneliner.

The malloc(0) check can also be simplified by replacing it with the AC_FUNC_MALLOC macro.

These are only two candidates I've found so far, there are probably more hence this ticket.

Child Tickets

Change History (2)

comment:1 Changed 4 years ago by cypherpunks

Actually AC_CHECK_DECLS should be used instead of AC_CHECK_DECL because it defines HAVE_DECL_symbol for us.

comment:2 Changed 3 years ago by nickm

Keywords: autotools build technical-debt added
Note: See TracTickets for help on using tickets.