Opened 8 months ago

Closed 8 months ago

#21026 closed defect (fixed)

Remove the abort handler in the backtrace generator

Reported by: cypherpunks Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.2-alpha
Severity: Normal Keywords: review-group-14
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The abort handler in the backtrace generator calls exit(3) which is not asynchronous-signal-safe. Calling exit(3) in this context is undefined behavior according to the C standard. See https://www.securecoding.cert.org/confluence/x/34At for more information.

FWICT the handler is meant to force the backtrace generator to always have an zero exit code. How the generator is currently used its exit code does not matter so the handler can probably be removed.

Patch coming soon after some testing.

Child Tickets

Attachments (1)

0001-Remove-abort-handler-from-the-backtrace-generator.patch (2.1 KB) - added by cypherpunks 8 months ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 months ago by cypherpunks

Status: newneeds_review
Version: Tor: 0.2.5.2-alpha

The backtrace generator (and the abort handler) was added in commit 56e3f056e9a03015aa55392a8028e2cbe097a0fb which is Tor version 0.2.5.2-alpha.

comment:2 Changed 8 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.0.x-final

Honestly, I have no idea why I ever put an abort handler there.

comment:3 Changed 8 months ago by nickm

Keywords: review-group-14 added

comment:4 Changed 8 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged!

Note: See TracTickets for help on using tickets.