Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#21037 closed defect (implemented)

Scary log message "AAAA...AAA" in connection_or_set_identity_digest()

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.3.0.1-alpha
Severity: Normal Keywords:
Cc: Actual Points: .1
Parent ID: Points: .1
Reviewer: dgoulet Sponsor:

Description

On moria1 running today's 0.3.0.1-alpha-dev, I see these info-level logs:

Dec 19 20:42:39.727 [info] connection_or_set_identity_digest(): Set identity digest for 0x1369a250 ((null)): FFD94A523D3A66323E3E4F7707AFCBD44A8D38C4 <null>.
Dec 19 20:42:39.727 [info] connection_or_set_identity_digest():    (Previously: 0000000000000000000000000000000000000000 AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA)

That last part reminds me of elsewhere in our code where we do

    memwipe(mem, 0xAA, memlen); /* poison memory */

Coincidence? I think it is, because I bet AAA..AAA is the base64 of 000..000, since I see ed25519_fmt() returns a base64 thing.

Still, I wonder if we might do a smarter log message for the case where the key used to be unset, since I'm not the only person who is going to see this line and be concerned.

Child Tickets

Change History (6)

comment:1 Changed 5 months ago by nickm

  • Milestone set to Tor: 0.3.0.x-final
  • Points set to .1

comment:2 Changed 5 months ago by nickm

  • Actual Points set to .1
  • Status changed from new to needs_review

Implementation in ticket21037. It replaces AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA with <unset>.

comment:3 Changed 4 months ago by dgoulet

  • Status changed from needs_review to merge_ready

lgtm;

comment:4 Changed 4 months ago by dgoulet

  • Reviewer set to dgoulet

comment:5 Changed 4 months ago by nickm

  • Resolution set to implemented
  • Status changed from merge_ready to closed

comment:6 Changed 4 months ago by nickm

(merged)

Note: See TracTickets for help on using tickets.