#21086 closed enhancement (implemented)

Migrate from pycrypto

Reported by: atagar Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords: descriptor
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Stem uses pycrypto as an optional dependency to validate descriptor signatures. Seems pycrypto is no longer maintained.

Quick search comes up with cryptography and pycryptodome as some possible alternatives.

Child Tickets

Change History (3)

comment:1 Changed 10 months ago by patrickod

Looking into this today. I suspect that replacement using the cryptography library will be quite straightforward. I'll post a public branch of my work when I have results to share.

comment:2 Changed 10 months ago by patrickod

Status: newneeds_review

https://github.com/patrickod/stem/pull/2 replaces pycrypto with the cryptography library which is produced by the same Python Cryptography Authority that develops the pynacl library that we're using in #21558

comment:3 Changed 10 months ago by atagar

Resolution: implemented
Status: needs_reviewclosed

Perfect, thanks Patrick! Great work, very much appreciated.

Pushed with a few minor tweaks.

Note: See TracTickets for help on using tickets.