#21091 closed enhancement (fixed)

Hide the "Check for Tor Browser Update..." menu entry when running under the sandbox.

Reported by: yawning Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201701R
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Since I punted on full integration with torbutton in the sandboxed-tor-browser 0.0.3 release due to time constraints (and the relatively large patch that would be required), I opted for a simpler solution that will hopefully be acceptable for all torbutton branches.

If the TBB_SANDBOX env var is linux-v0, then the "Check for Tor Browser Update..." menu entry should be hidden.

Child Tickets

Change History (8)

comment:1 Changed 20 months ago by yawning

Status: newneeds_review

https://git.schwanenlied.me/yawning/torbutton/commit/9abc7fd22ffb3c6421d2fba817080d95966cbb9c

This works, without the env var (existing behavior), with the env var set to what I set (relevant items hidden), and with the env var set to something I will set in the future (existing behavior again).

comment:2 Changed 20 months ago by mcs

Cc: brade mcs added

These changes look okay to me.
Do you expect to trigger other special behavior via the TOR_SANDBOX env variable? If not and if there is a chance that other people might want to hide this menu item as well, we should use a more specific env var name such as TOR_HIDE_UPDATE_CHECK_UI.

comment:3 Changed 20 months ago by yawning

Eventually, I want to make the menu item work instead of hiding it, but since the sandbox is bundle version aware, having to do something different on my end isn't a big deal.

TOR_HIDE_UPDATE_CHECK_UI works for, and since other people want it (IIRC one of the patches in #20557 is to do something similar) that's probably better.

I'm on vacation (TM) this week, so feel free to change it in a branch, if not I'll do it this weekend or something, and someone could probably also close #20083 in favor of this, if we're going the env var route (Help->About Tor Browser's button gets disabled if you use autoconfig.js/mozilla.cfg, so I'm less worried about that now).

comment:4 Changed 20 months ago by gk

Keywords: TorBrowserTeam201701 added
Status: needs_reviewneeds_revision

comment:5 Changed 20 months ago by yawning

Status: needs_revisionneeds_review

https://git.schwanenlied.me/yawning/torbutton/commit/a067307f918aeaf474a95038b25a82ba95f3029f

I changed the env var (and updated the sandbox code) as discussed. Setting it to 1 hides things, setting it to anything else, or omitting it leaves things visible.

comment:6 Changed 20 months ago by mcs

In Torbutton, for similar env vars we just check for presence (e.g., for TOR_NO_DISPLAY_NETWORK_SETTINGS which is handled nearby). For consistency, Kathy and I think we should use the same approach for TOR_HIDE_UPDATE_CHECK_UI. Here is a revised patch:

https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug21091-01&id=dd927687ed22a2e8a8e880e92c6f5b8273c737c9

comment:7 Changed 20 months ago by yawning

That's fine by me.

comment:8 Changed 19 months ago by gk

Keywords: TorBrowserTeam201701R added; TorBrowserTeam201701 removed
Resolution: fixed
Status: needs_reviewclosed

Pushed to master with commit dd927687ed22a2e8a8e880e92c6f5b8273c737c9.

Note: See TracTickets for help on using tickets.