Opened 8 months ago

Closed 7 months ago

#21096 closed enhancement (fixed)

Check for the tor- prefix in changes files

Reported by: cypherpunks Owned by: cypherpunks
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In commit 9e0d3eea4674572ad1a4c517b37b12bf35557bbb/tor the version syntax was normalized by removing the tor- prefix from versions in the change log entries.

For automatic detection of these instances it may be easier to enhance the change file linter.

Child Tickets

Attachments (2)

0001-Fix-coding-style-issues-in-the-changes-file-linter.patch (2.2 KB) - added by cypherpunks 8 months ago.
0002-Warn-on-Tor-versions-with-the-tor-prefix.patch (1.2 KB) - added by cypherpunks 8 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 months ago by cypherpunks

Owner: set to cypherpunks
Status: newassigned

Changed 8 months ago by cypherpunks

comment:2 Changed 8 months ago by cypherpunks

Status: assignedneeds_review

While working on the changes file linter i ran it through flake8 for checking my additions. flake8 found some existing issues which i fixed in patch 0001. Patch 0002 adds the tor- prefix check and a changes file.

comment:3 Changed 8 months ago by nickm

Milestone: Tor: 0.3.0.x-final

comment:4 Changed 7 months ago by dgoulet

Status: needs_reviewmerge_ready

lgtm.

comment:5 Changed 7 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.