apparent inconsistency in prop264

In A.1, "the protocol list for all current Tor versions" says HSDir=1, there is no version 2. But in A.2, both clients and relays are required to support HSDir=2, which A.1 just said does not exist.

https://gitweb.torproject.org/torspec.git/tree/proposals/264-subprotocol-versions.txt#n304

changed milestone to %Tor: 0.3.3.x-final

added component::core tor/tor doc easy milestone::Tor: 0.3.3.x-final priority::medium resolution::implemented severity::normal status::closed tor-spec type::defect labels

It looks like there shouldn't be a HSDir=1 but it was there in the original draft by accident and only partially got fixed?

https://gitweb.torproject.org/torspec.git/commit/?id=ec90286c06f86d3896a062fff88387b5c001b16f https://gitweb.torproject.org/torspec.git/commit/?id=232a381bdf97bc3ce474ae8cf9bb169a524814b9

Trac:
Milestone: N/A to Tor: 0.2.9.x-final

Tor 0.3 stable is out now and this still isn't clarified.

Trac:
Milestone: Tor: 0.2.9.x-final to Tor: 0.3.1.x-final

You're correct; the required/recommended protocols should have listed HSDir=1, after all the renumberings. (And they do; see latest consensus and/or dirserv.c code to fill in the fields.)

I've amended tor-spec.txt with 8692de910d3b56da27f17f890472ec91cf2014e7: Now that proposal 264 is closed, tor-spec.txt is the canonical location for subprotocol documentation.

Trac:
Resolution: N/A to fixed
Status: new to closed

Consistently use tor-spec across all tickets (add tor-spec).

Trac:
Keywords: N/A deleted, tor-spec added

Consistently use tor-spec across all tickets (remove torspec).

Trac:
Keywords: torspec deleted, N/A added

I've amended tor-spec.txt with 8692de910d3b56da27f17f890472ec91cf2014e7 Bad commit reference: 8692de910d3b56da27f17f890472ec91cf2014e7

That commit isn't in the repo and it still says HSDir=2 is recommended+required, which like you said is a mismatch with dirserv.c.

Trac:
Status: closed to reopened
Resolution: fixed to N/A

I assume this commit exists somewhere, it just hasn't been merged.

Trac:
Keywords: N/A deleted, doc, easy added
Status: reopened to merge_ready
Milestone: Tor: 0.3.1.x-final to Tor: 0.3.3.x-final

Thanks for the heads-up! I just found it on an old laptop, and merged it to master on torspec.

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

closed

moved to tpo/core/tor#21109 (closed)