Opened 22 months ago

Closed 9 months ago

#21109 closed defect (implemented)

apparent inconsistency in prop264

Reported by: cypherpunks Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, easy, doc
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In A.1, "the protocol list for all current Tor versions" says HSDir=1, there is no version 2. But in A.2, both clients and relays are required to support HSDir=2, which A.1 just said does not exist.

https://gitweb.torproject.org/torspec.git/tree/proposals/264-subprotocol-versions.txt#n304

Child Tickets

Change History (10)

comment:1 Changed 22 months ago by cypherpunks

Last edited 22 months ago by cypherpunks (previous) (diff)

comment:2 Changed 22 months ago by nickm

Milestone: Tor: 0.2.9.x-final

comment:3 Changed 18 months ago by cypherpunks

Tor 0.3 stable is out now and this still isn't clarified.

comment:4 Changed 18 months ago by nickm

Milestone: Tor: 0.2.9.x-finalTor: 0.3.1.x-final

comment:5 Changed 18 months ago by nickm

Resolution: fixed
Status: newclosed

You're correct; the required/recommended protocols should have listed HSDir=1, after all the renumberings. (And they do; see latest consensus and/or dirserv.c code to fill in the fields.)

I've amended tor-spec.txt with 8692de910d3b56da27f17f890472ec91cf2014e7: Now that proposal 264 is closed, tor-spec.txt is the canonical location for subprotocol documentation.

comment:6 Changed 15 months ago by teor

Keywords: tor-spec added

Consistently use tor-spec across all tickets (add tor-spec).

comment:7 Changed 15 months ago by teor

Keywords: torspec removed

Consistently use tor-spec across all tickets (remove torspec).

comment:8 Changed 9 months ago by cypherpunks

Resolution: fixed
Status: closedreopened

I've amended tor-spec.txt with 8692de910d3b56da27f17f890472ec91cf2014e7

Bad commit reference: 8692de910d3b56da27f17f890472ec91cf2014e7

That commit isn't in the repo and it still says HSDir=2 is recommended+required, which like you said is a mismatch with dirserv.c.

Last edited 9 months ago by cypherpunks (previous) (diff)

comment:9 Changed 9 months ago by teor

Keywords: easy doc added
Milestone: Tor: 0.3.1.x-finalTor: 0.3.3.x-final
Status: reopenedmerge_ready

I assume this commit exists somewhere, it just hasn't been merged.

comment:10 Changed 9 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Thanks for the heads-up! I just found it on an old laptop, and merged it to master on torspec.

Note: See TracTickets for help on using tickets.