Opened 2 years ago

Closed 2 years ago

#21118 closed defect (fixed)

circuit_get_global_origin_circuit_list() returns the wrong list

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Major Keywords: review-group-15
Cc: Actual Points:
Parent ID: #20921 Points: .1
Reviewer: dgoulet Sponsor:

Description

It returns global_circuitlist, when it should return global_origin_circuit_list.

Found while working on #20921.

I'm surprised this doesn't cause crash bugs all over, every time we call circuit_expire_waiting_for_better_guard().

Child Tickets

Change History (9)

comment:1 Changed 2 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 2 years ago by nickm

Fixed as part of my ticket20921 branch.

comment:3 Changed 2 years ago by nickm

Status: acceptedneeds_review

comment:4 Changed 2 years ago by dgoulet

Status: needs_reviewneeds_revision

I do not see the fix in that branch for this.

circuit_get_global_list() still returns global_circuitlist instead of global_origin_circuit_list which is what the description of this ticket is stating.

comment:5 Changed 2 years ago by nickm

Status: needs_revisionneeds_review

Whoops! I don't know what happened to that commit. Added one again. Sorry!

comment:6 Changed 2 years ago by nickm

Keywords: review-group-15 added

comment:7 Changed 2 years ago by dgoulet

Status: needs_reviewmerge_ready

lgtm!

comment:8 Changed 2 years ago by dgoulet

Reviewer: dgoulet

comment:9 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.