Opened 10 months ago

#21119 new enhancement

Deprecate and replace type_getarray_val()

Reported by: nickm Owned by: nickm
Priority: Medium Milestone:
Component: Core Tor/Trunnel Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In the first version of the introduce1 branch, the type_getarray_val() accessor was used erroneously in a way that could have resulted in a buffer overflow.

That bodes ill for its usability. And since Trunnel is supposed to make it hard for us to make mistakes, we should consider fixing this.

Brainstorming replacement ideas:

  • type_copyinto_val(object, input, input_len);
  • type_copyfrom_val(object, target, target_len);
  • type_getarray_checked(object, array, need_len);

Child Tickets

Change History (0)

Note: See TracTickets for help on using tickets.