Opened 5 months ago

Closed 4 months ago

#21123 closed defect (fixed)

Remove redundant code in options_transition_allowed

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.4-alpha
Severity: Normal Keywords:
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: dgoulet Sponsor:

Description

The code that prevents attempted PidFile changes while Sandbox is active will never be executed, because attempted PidFile changes are blocked earlier in the function.

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by teor

  • Actual Points set to 0.1
  • Status changed from new to needs_review
  • Version set to Tor: 0.2.5.4-alpha

Please see my branch bug21123 on github.

comment:2 Changed 4 months ago by dgoulet

  • Reviewer set to dgoulet
  • Status changed from needs_review to merge_ready

lgtm;

comment:3 Changed 4 months ago by nickm

  • Resolution set to fixed
  • Status changed from merge_ready to closed

Merged!

Note: See TracTickets for help on using tickets.