Opened 3 years ago

Closed 3 years ago

#21144 closed enhancement (fixed)

remove 604 checkstyle complaints from metrics-lib

Reported by: iwakeh Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Library Version:
Severity: Normal Keywords: metrics-help
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Mostly for test classes.
Run ant checks to see the items.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by karsten

Aiii, 604. I'd say whoever starts working on this should first say so on this ticket and ask whether there are any other merges planned, wait for 12 hours, then start making changes, and submit a patch within the next 12 hours. Otherwise this is going to produce merge conflicts with high certainty.

comment:2 Changed 3 years ago by karsten

Owner: changed from metrics-team to karsten
Status: newaccepted

I'll work on this tomorrow morning.

comment:3 Changed 3 years ago by karsten

Status: acceptedneeds_review

Please review my branch task-21144. Thanks!

comment:4 Changed 3 years ago by karsten

I'd like to merge this soon, mind taking a quick look?

comment:5 Changed 3 years ago by iwakeh

Status: needs_reviewmerge_ready

Sure.

Good to have these cleaned-up.

All changes look fine, tests, coverage, and checks pass.
=> Ready for merge.

comment:6 Changed 3 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Merged, closing. Thanks!

Note: See TracTickets for help on using tickets.