Opened 10 months ago

Last modified 4 days ago

#21145 needs_revision enhancement

Adapt ExoneraTor to using metrics-base

Reported by: iwakeh Owned by: iwakeh
Priority: Medium Milestone:
Component: Metrics/ExoneraTor Version:
Severity: Normal Keywords: metrics-2017
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

see #20596

Child Tickets

Change History (8)

comment:1 in reply to:  description Changed 10 months ago by iwakeh

Replying to iwakeh:

see #20596

as far as feasible.

comment:2 Changed 4 weeks ago by karsten

Summary: adapt ExoneraTor to using metrics-baseAdapt ExoneraTor to using metrics-base

Capitalize summary.

comment:3 Changed 3 weeks ago by karsten

Keywords: metrics-2018 added

comment:4 Changed 3 weeks ago by karsten

Keywords: metrics-2017 added; metrics-2018 removed

comment:5 Changed 9 days ago by iwakeh

Owner: changed from metrics-team to iwakeh
Status: newaccepted

comment:6 Changed 8 days ago by iwakeh

Status: acceptedneeds_review

Please review these changes, which are optimistically based on the patch for #19624 (two commits for checkstyle fixes and using commons-lang3).

comment:7 Changed 8 days ago by iwakeh

There is also an update to the latest metrics-lib 2.1.1 in the patch.

comment:8 Changed 4 days ago by karsten

Status: needs_reviewneeds_revision

Hmm, the patch looks good, but I'm having trouble executing the JAR file:

$ java -jar generated/dist/exonerator-1.0.0-dev.jar 
11:33:38.330 [main] ERROR org.torproject.exonerator.ExoneraTorDatabaseImporter - Could not connect to database.  Exiting.
java.sql.SQLException: No suitable driver found for jdbc:postgresql:exonerator
	at java.sql.DriverManager.getConnection(DriverManager.java:689)
	at java.sql.DriverManager.getConnection(DriverManager.java:270)
	at org.torproject.exonerator.ExoneraTorDatabaseImporter.openDatabaseConnection(ExoneraTorDatabaseImporter.java:102)
	at org.torproject.exonerator.ExoneraTorDatabaseImporter.main(ExoneraTorDatabaseImporter.java:51)

Any idea what could be missing?

(Minor nitpick: let's also remove the run-exonerator.sh file in this change. I can do that when merging the branch.)

Note: See TracTickets for help on using tickets.