Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#21156 closed defect (fixed)

Include xz-1.5.jar in the Onionoo release .jar file

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone: Onionoo 3.2-1.1.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When I started a temporary Onionoo instance for #20994, I noticed that the release .jar file does not contain xz-1.5.jar. The result is that it cannot process xz-compressed tarballs in in/archive/. Should we add that? If so, here's what I did, but I'm not certain whether that was the right way to add it:

diff --git a/build.xml b/build.xml
index 438cdc5..3c2ad5c 100644
--- a/build.xml
+++ b/build.xml
@@ -51,6 +51,7 @@
     <include name="logback-classic-1.1.2.jar"/>
     <include name="logback-core-1.1.2.jar"/>
     <include name="slf4j-api-1.7.7.jar"/>
+    <include name="xz-1.5.jar"/>
   </patternset>
 
   <patternset id="web" >

But I did not check what other effects this change might have.

Oh, and we'd probably want to add these lines to the LICENSE file (copied from CollecTor's LICENSE file):

--------------------------------------------------------------------------

XZ binaries have been put into the public domain.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by karsten

Status: newneeds_review

comment:2 Changed 2 years ago by iwakeh

Status: needs_reviewmerge_ready

That's the right way to add the library to the jar.
But, it never was in there? Why didn't that cause a problem before?
It's been a dependency of descriptor since descriptor-1.1.0.
Was it manually added to the classpath?

Change is merge ready.

comment:3 Changed 2 years ago by iwakeh

Milestone: Onionoo 3.2-1.1.0

Set to next release milestone 3.2-1.1.0

comment:4 Changed 2 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks for looking, added!

This apparently did not cause problems so far, because nobody fed xz-compressed archives into an Onionoo instance, but only uncompressed archives and recent descriptors. And it seems that Apache Commons Compress only loads those classes when it encounters an xz-compressed file.

Closing.

comment:5 Changed 2 years ago by iwakeh

There won't be 3.1-1.1.0.

Note: See TracTickets for help on using tickets.