Opened 9 months ago

Closed 9 months ago

#21166 closed defect (fixed)

Missing equal sign in the router template

Reported by: cypherpunks Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Atlas Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The family members section on the router page is missing an equal sign before the class name.

diff --git a/templates/details/router.html b/templates/details/router.html
index 50d0ccc..907f17d 100644
--- a/templates/details/router.html
+++ b/templates/details/router.html
@@ -90,7 +90,7 @@
     <dt><span class="tip" data-content="Date and time when the relay was last (re-)started." data-original-title="Last restarted">Last Restarted</span></dt>
     <dd><%= relay.get('last_restarted') %></dd>
 
-    <dt><span class"tip" data-content="Other family members of this relay." data-original-title="Family Members">Family Members</span></dt>
+    <dt><span class="tip" data-content="Other family members of this relay." data-original-title="Family Members">Family Members</span></dt>
     <dd><pre><% if (relay.get('effective_family') !== null) { %><% _.each(relay.get('effective_family'), function(member) { %><% var valid = member.match(RegExp("^\$[A-F0-9]{40}$")); %>
 <% if (valid) { %><a href="#details/<%= member.replace('$', '') %>" title="Effective family member"><% } %><%= member %><% if (valid) { %></a><% }}); %><% } %>
 <% if (relay.get('alleged_family') !== null) { %><% _.each(relay.get('alleged_family'), function(member) { %><% var valid = member.match(RegExp("^\$[A-F0-9]{40}$")); %>

Child Tickets

Change History (3)

comment:1 Changed 9 months ago by cypherpunks

Status: newneeds_review

comment:2 Changed 9 months ago by karsten

Yup, we should fix this.

I wonder, are there more bugs like this? Are there tools to check these things?

comment:3 Changed 9 months ago by irl

Resolution: fixed
Status: needs_reviewclosed

Merged, thanks. (:

Note: See TracTickets for help on using tickets.