Opened 4 years ago

Closed 4 years ago

#21175 closed defect (fixed)

Line breaks separate checkboxes from labels in userstats-bridge-transport.html

Reported by: dcf Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by dcf)

The checkboxes and labels wrap such that the checkbox sometimes is left at the end of a line, separated from its label:

This is the way it's currently formatted in website/web/WEB-INF/graph.jsp:

<input type="checkbox" name="transport" value="${row[0]}" id="transport_${row[0]}"${row[1]}>
<label class="checkbox-label" for="transport_${row[0]}">${row[2]}</label>

I did some experiments in the DOM editor and this fixes the problem and looks good with the current CSS (make input a child of label rather than use a for attribute):

<label class="checkbox-label">
  <input type="checkbox" name="transport" value="${row[0]}" id="transport_${row[0]}"${row[1]}> ${row[2]}

(Actually, the percentile checkboxes already work that way:)

<label class="checkbox-label">
  <input type="checkbox" name="n" value="${row[0]}"${row[1]}> ${row[0]}

Child Tickets

Attachments (1)

transport-wrap.png (4.3 KB) - added by dcf 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by dcf

Attachment: transport-wrap.png added

comment:1 Changed 4 years ago by dcf

Description: modified (diff)

comment:2 Changed 4 years ago by karsten

Resolution: fixed
Status: newclosed

Oh, you're right! Thanks a lot for the report and detailed analysis! Fixed. Closing.

Note: See TracTickets for help on using tickets.