Opened 14 months ago

Closed 5 months ago

#21177 closed enhancement (implemented)

Add support for parsing bridge-distribution-request lines in Stem

Reported by: isis Owned by: atagar
Priority: High Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

From #18329, we added a new bridge-server-descriptor line: bridge-distribution-request, which, if set to "none" should tell BridgeDB not to distribute a bridge. This allows, for example, BridgeDB to avoid distributing the default Tor Browser bridges, and allows other bridges to not be distributed, but to still submit their usage statistics for Metrics.

Child Tickets

Change History (7)

comment:1 Changed 14 months ago by atagar

Status: newneeds_information

Hi Isis, sorry this went so long without a reply. Been down with the flu.

Took a quick peek at the CollecTor docs but not spotting this new field...

https://collector.torproject.org/#bridge-descriptors

Is it live? Could you please provide a descriptor with examples of this (both the none and the non-none values)? I'd also like the field to be documented before we add it to Stem.

comment:2 Changed 13 months ago by atagar

Hi isis, did you still want this? If so then I need some information.

comment:3 Changed 6 months ago by atagar

Resolution: user disappeared
Status: needs_informationclosed

comment:4 Changed 5 months ago by isis

Resolution: user disappeared
Status: closedreopened

Hi atagar! There's a spec patch from #18329 which should be usable to implement this. It's not live in Tor yet, since #18329 is waiting (among other things) for it to be parseable by BridgeDB (and hence Stem), before merging it since it would be bad if operators thought their bridge was private and it wasn't actually respected.

comment:5 Changed 5 months ago by atagar

Ha! So spec patch is awaiting tor which is awaiting bridgedb which is awaiting stem which is awaiting the spec. Thanks, you made me chuckle this morning. :P

No problem, this is a trivial field to add.

comment:6 Changed 5 months ago by atagar

Stem support pushed...

https://gitweb.torproject.org/stem.git/commit/?id=3eb5941

No big rush but this will need to be followed up with the tor spec change otherwise I'll revert this in a future revision (I have a 'must be in the spec' policy because Stem's predecessor, TorCtl, accumulated support for fields that never existed which was confusing). Happy to make an exception here, just giving a head's up that this will need to be followed up with the addition on tor's side.

Feel free to reopen if ya need anything else.

comment:7 Changed 5 months ago by atagar

Resolution: implemented
Status: reopenedclosed
Note: See TracTickets for help on using tickets.