Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#21193 closed enhancement (fixed)

Prop271 spec: High level circuit creation and guard selection overview

Reported by: chelseakomlo Owned by: chelseakomlo
Priority: Low Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Minor Keywords: review-group-15, tor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

This is to track additions to prop271 spec, specifically a section adding a 1000 foot overview.

Child Tickets

Change History (13)

comment:1 Changed 4 years ago by chelseakomlo

I have a patch at: git@github.com:chelseakomlo/torspec.git, branch prop271

Open questions are:

  • How much information should be here versus other spec files?
  • What should be defined in the glossary versus prop271?
  • How much detail is necessary? I didn't include much information on the guard picking algorithm as I didn't want to have this section be redundant. But there is likely necessary info missing.

comment:2 Changed 4 years ago by chelseakomlo

Status: newneeds_review

comment:3 Changed 4 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.0.x-final

comment:4 Changed 4 years ago by asn

LGTM. I think the section added is a fine overview section. Perhaps it can even be moved above section 2. State instances, so that it's beneath the motivation section like a true overview section would be.

WRT how much detail is necessary, I think it could be useful to include some further information on what it means to use a circuit or to let it wait. This has to do with how streams are assigned to circuits, and perhaps it would be useful for readers. Anyhow, this does not need to happen in this ticket; it's just some information that would have been useful to me when I originally read the proposal.

comment:5 Changed 4 years ago by nickm

Owner: set to chelseakomlo
Status: needs_reviewassigned

setting owner

comment:6 Changed 4 years ago by nickm

Status: assignedneeds_review

(asn, should this be merge_ready?)

comment:7 Changed 4 years ago by nickm

Keywords: review-group-15 added

comment:8 Changed 4 years ago by nickm

Reviewer: nickm

comment:9 Changed 4 years ago by asn

Status: needs_reviewmerge_ready

comment:10 Changed 4 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged!

comment:11 Changed 4 years ago by chelseakomlo

Oh, great! Super fast, thanks everyone!

I will follow up on the items asn proposed above.

comment:12 Changed 3 years ago by teor

Keywords: tor-spec added

Consistently use tor-spec across all tickets (add tor-spec).

comment:13 Changed 3 years ago by teor

Keywords: torspec removed

Consistently use tor-spec across all tickets (remove torspec).

Note: See TracTickets for help on using tickets.