Opened 3 years ago

Last modified 3 years ago

#21224 new defect

Youtube fullscreen errorr in TBB fullscreen mode on MacOS 10.12

Reported by: exatto Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-usability, tbb-6.5-regression, TorBrowserTeam201702
Cc: arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Since the window resizing logic was updated in the 6.5 alphas there is a problem with fullscreen videos on Youtube.
I'm on a fully up to date MacOS Sierra installation and when I put the Tor Browser in the native Mac fullscreen mode and then put a Youtube video in fullscreen from that window it only shows in a small rectangle in the upper left corner of the screen.
Other websites with video players don't have this problem.

When I take Tor Browser back out of its fullscreen mode then the Youtube video works fullscreen as normal again but it seems it is overlaying the window and not using the native Mac fullscreen apis.

I can make a screenshot if necessary but it should be easily reproducible.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by mcs

I was able to reproduce this problem on a macOS 10.12.2 system. It does not happen in Tor Browser 6.0.8 and as you said it only happens when the window is in OSX's full screen mode. I expect most people do not use that mode with Tor Browser, but I do not really know.

comment:2 Changed 3 years ago by exatto

FWIW I almost always use my browsers in the full screen mode.

This has only started since the recent patches to move the window resizing logic into a C++ patch. I think this is since the 6.5a4 release (as per https://blog.torproject.org/blog/tor-browser-65a4-released). This is an obvious regression so I hope this can be fixed before the eventual upstreaming to Firefox.

comment:3 Changed 3 years ago by gk

Cc: arthuredelstein added
Keywords: TorBrowserTeam201701 tbb-usability added

Arthur: Could you give that a quick look? If it's an easy patch this might be something we could squeeze into 6.5.

comment:4 Changed 3 years ago by arthuredelstein

I have found a solution for this, but it's going to require careful testing on all platforms. I expect it will take me at least another day.

comment:5 Changed 3 years ago by gk

Keywords: tbb-6.5-regression added

comment:6 Changed 3 years ago by gk

Keywords: TorBrowserTeam201702 added; TorBrowserTeam201701 removed

Moving our tickets to Feb 2017.

Note: See TracTickets for help on using tickets.