Fix W3C validator issues

Validating Atlas with the W3C Markup Validation Service shows some issues.

Patch is coming once i have a ticket number.

added component::metrics/relay search owner::irl priority::medium resolution::fixed severity::normal status::closed type::defect labels

Trac:
0001-Fix-W3C-markup-validation-service-issues.patch

Trac:
Status: new to needs_review

Merged, thanks! (:

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Trac:
0001-Remove-the-action-attribute-from-the-search-form.patch

The changes in my initial patch weren't good enough for the validator. I've attached an additional patch which fixes the remaining issue.

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Status: reopened to needs_review

Thanks for the patch cypherpunks, but I don't think this can be merged.

We do kinda need an action there. The reason it's empty is because it's for the same page. Apparently browsers can cope with this, and semantically action="" is the same as just action, which is how this worked before. I think removing it would not be the best course to take as this would change (potentially, but I'm not a browser expert) the semantic meaning.

If it needs to be non-empty, perhaps action="#" is the answer we're looking for. I'll test that out when I get some time, if you have time beforehand to check then it would be appreciated.

(You may also be interested in #21274 (moved))

Trac:
Status: needs_review to needs_revision

Like i mention in the commit message of [0001-Remove-the-action-attribute-from-the-search-form.patch], search form submits are caught by an JavaScript event so the action attribute is unused. Without JavaScript the page is simply refreshed and nothing is submitted which is equal to the current behavior.

Looking at the HTML 5 specification (https://www.w3.org/TR/html5/forms.html#attr-fs-action) which we claim to be following in the doctype, you are indeed correct that the action attribute can be removed from the form element.

Tested that this is functional and that it now passes W3C validation.

Merged, thanks for your work on this. (:

Trac:
Resolution: N/A to fixed
Status: needs_revision to closed

closed

mentioned in issue #21274 (moved)