#21240 closed task (fixed)

Create patches to fix mingw-w64 compilation of Firefox ESR 52

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, TorBrowserTeam201704R, GeorgKoppen201703, tbb-7.0-must-nightly
Cc: Actual Points:
Parent ID: #21147 Points:
Reviewer: Sponsor: Sponsor4

Description

We probably need some (additional) patches to get Tor Browser compiled with mingw-w64. This is the ticket for coordinating this task.

Child Tickets

TicketStatusOwnerSummaryComponent
#18831closedtbb-teamWe need Yasm >= 1.2.0 to build ESR 52Applications/Tor Browser

Change History (21)

comment:1 Changed 20 months ago by gk

Okay, the attached 6 patches are needed to get esr52 (i.e. current mozilla-beta) successfully packaged and built. We might need more to get accessibility support going again.

comment:2 Changed 20 months ago by gk

I tested a build with the usual modifications we need to apply to get it running on Windows and it worked on a Windows 7 machine. I surfed a bit (read news and watched some youtube videos) and no crashes or other things that would worry me. \o/

comment:3 Changed 20 months ago by gk

Keywords: TorBrowserTeam201702 added

To get back to the status quo we need to fix the accessibility issues. Currently the build breaks with stdole2.tlb not being found which is due to https://bugzilla.mozilla.org/show_bug.cgi?id=1288199.

We probably need Jacek's https://sourceforge.net/p/mingw-w64/mailman/message/35635327/ being properly checked-in. It might be the case that we get a new binary blob that way. If that's the case we want to find a way to build that .tlb from source. I tried a bit but failed so far.

comment:4 Changed 20 months ago by gk

Sponsor: Sponsor4

Sponsor4 as well

comment:5 Changed 20 months ago by gk

Okay, here comes the accessibility related patch. we'll need an additional gitian patch if we don't want to ship the binary .tlb blob that is in the tree.

comment:6 Changed 19 months ago by gk

Keywords: tbb-7.0-must added

comment:7 Changed 19 months ago by gk

Keywords: TorBrowserTeam201703 added; TorBrowserTeam201702 removed

Moving tickets to March

comment:8 Changed 19 months ago by gk

Keywords: GeorgKoppen201703 added

Adding to my plate.

comment:9 Changed 18 months ago by gk

Keywords: tbb-7.0-must-nightly added

We want those tickets for our first ESR52 nightlies.

comment:10 Changed 18 months ago by gk

Keywords: GeorgKoppen201703R added; GeorgKoppen201703 removed
Status: newneeds_review

The tor-browser changes are in my bug_21240 (the last 6 patches). The tor-browser-bundle changes are in my bug_21240_v2 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21240_v2&id=546273fb78b4dc7bf346505bf6262bc779dacb2c). The change in #18831 is needed as well.

comment:11 Changed 18 months ago by gk

Keywords: TorBrowserTeam201704R GeorgKoppen201703 added; TorBrowserTeam201703 GeorgKoppen201703R removed

comment:12 Changed 18 months ago by gk

Keywords: tbb-7.0-must removed

No need to use somewhat duplicated keywords.

comment:13 in reply to:  10 Changed 18 months ago by boklm

Replying to gk:

The tor-browser changes are in my bug_21240 (the last 6 patches). The tor-browser-bundle changes are in my bug_21240_v2 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21240_v2&id=546273fb78b4dc7bf346505bf6262bc779dacb2c). The change in #18831 is needed as well.

The tor-browser and tor-browser-bundle changes look good to me.

comment:14 Changed 18 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

The tor-browser-bundle change is in commit b5beb33b57643ff83838337ded870511599d45f5 on master, the patches for tor-browser are on tor-browser-52.0.2esr-7.0-2 in commit 70fd0587c18f111fbae0e64b03ca7a273e5c0e94, b63cc0d449954e51a72721f34e3628e75daba59a, d4b359c42ae2dbd3ab6406cdf99db796602aaedf, 1be3aec99fc7731563715dcfc7724fcd7ca4a6fb,
01f545c45a48f7805637b6eb0db26589dc079a96, and a6a430bf6393f51a778b8dfe19103ae708bfcc5c.

Note: See TracTickets for help on using tickets.