Create patches to fix mingw-w64 compilation of Firefox ESR 52

We probably need some (additional) patches to get Tor Browser compiled with mingw-w64. This is the ticket for coordinating this task.

added GeorgKoppen201703 TorBrowserTeam201704R component::applications/tor browser ff52-esr owner::tbb-team parent::21147 priority::medium resolution::fixed severity::normal sponsor::4 status::closed tbb-7.0-must-nightly type::task labels

Trac:
0001-Backport-of-tjr-s-patch-for-bug-1314979-for-mozilla-.patch

Trac:
0001-Backport-of-tjr-s-patch-for-bug-1331349-for-mozilla-.patch

Trac:
0001-Backport-of-tjr-s-patch-for-bug-1331939-for-mozilla-.patch

Trac:
0001-Avoiding-ffi_-undefined-reference-errors.patch

Trac:
0001-Avoiding-undefined-reference-error-nsThread-Resgiste.patch

Trac:
0001-Avoiding-reference-error-IID_IDirectDraw7.patch

Okay, the attached 6 patches are needed to get esr52 (i.e. current mozilla-beta) successfully packaged and built. We might need more to get accessibility support going again.

I tested a build with the usual modifications we need to apply to get it running on Windows and it worked on a Windows 7 machine. I surfed a bit (read news and watched some youtube videos) and no crashes or other things that would worry me. \o/

To get back to the status quo we need to fix the accessibility issues. Currently the build breaks with stdole2.tlb not being found which is due to https://bugzilla.mozilla.org/show_bug.cgi?id=1288199.

We probably need Jacek's https://sourceforge.net/p/mingw-w64/mailman/message/35635327/ being properly checked-in. It might be the case that we get a new binary blob that way. If that's the case we want to find a way to build that .tlb from source. I tried a bit but failed so far.

Trac:
Keywords: N/A deleted, TorBrowserTeam201702 added

Sponsor4 as well

Trac:
Sponsor: N/A to Sponsor4

Okay, here comes the accessibility related patch. we'll need an additional gitian patch if we don't want to ship the binary .tlb blob that is in the tree.

Trac:
0001-Getting-Tor-Browser-to-build-with-accessibility-enab.patch

Trac:
Keywords: N/A deleted, tbb-7.0-must added

Moving tickets to March

Trac:
Keywords: TorBrowserTeam201702 deleted, TorBrowserTeam201703 added

Adding to my plate.

Trac:
Keywords: N/A deleted, GeorgKoppen201703 added

We want those tickets for our first ESR52 nightlies.

Trac:
Keywords: N/A deleted, tbb-7.0-must-nightly added

The tor-browser changes are in my bug_21240 (the last 6 patches). The tor-browser-bundle changes are in my bug_21240_v2 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21240_v2&id=546273fb78b4dc7bf346505bf6262bc779dacb2c). The change in #18831 (moved) is needed as well.

Trac:
Keywords: GeorgKoppen201703 deleted, GeorgKoppen201703R added
Status: new to needs_review

Trac:
Keywords: TorBrowserTeam201703, GeorgKoppen201703R deleted, TorBrowserTeam201704R, GeorgKoppen201703 added

No need to use somewhat duplicated keywords.

Trac:
Keywords: tbb-7.0-must deleted, N/A added

Replying to gk:

The tor-browser changes are in my bug_21240 (the last 6 patches). The tor-browser-bundle changes are in my bug_21240_v2 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21240_v2&id=546273fb78b4dc7bf346505bf6262bc779dacb2c). The change in #18831 (moved) is needed as well.

The tor-browser and tor-browser-bundle changes look good to me.

The tor-browser-bundle change is in commit b5beb33b57643ff83838337ded870511599d45f5 on master, the patches for tor-browser are on tor-browser-52.0.2esr-7.0-2 in commit 70fd0587c18f111fbae0e64b03ca7a273e5c0e94, b63cc0d449954e51a72721f34e3628e75daba59a, d4b359c42ae2dbd3ab6406cdf99db796602aaedf, 1be3aec99fc7731563715dcfc7724fcd7ca4a6fb, 01f545c45a48f7805637b6eb0db26589dc079a96, and a6a430bf6393f51a778b8dfe19103ae708bfcc5c.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#21240 (closed)