Opened 22 months ago

Closed 2 months ago

#21263 closed defect (fixed)

Torbutton's readme still talks about toggling

Reported by: arma Owned by: traumschule
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

https://gitweb.torproject.org/torbutton.git/tree/README
has the very first FAQ entry of "I can't click on links or hit reload after I toggle Tor! Why?"

and at the very end it says

   There is currently one known unfixed security issue with Torbutton: it is
   possible to unmask the javascript hooks that wrap the Date object to
   conceal your timezone in Firefox 2, and the timezone masking code does not
   work at all on Firefox 3.

and I bet a lot of the stuff in the middle is obsolete now too.

Child Tickets

Change History (11)

comment:1 Changed 22 months ago by gk

Component: Applications/TorbuttonApplications/Tor Browser
Keywords: tbb-torbutton added
Owner: set to tbb-team

comment:2 Changed 2 months ago by traumschule

can this be archived?

comment:3 in reply to:  2 Changed 2 months ago by gk

Replying to traumschule:

can this be archived?

Why? This is still a bug.

comment:4 Changed 2 months ago by traumschule

Owner: changed from tbb-team to traumschule
Status: newassigned

ok, let me look into it then.

comment:5 Changed 2 months ago by traumschule

Status: assignedneeds_review

comment:6 Changed 2 months ago by gk

Keywords: TorBrowserTeam201809R added

comment:7 Changed 2 months ago by gk

Keywords: TorBrowserTeam201809R removed
Status: needs_reviewneeds_revision

Thanks for the patch. Some nits:

a/firefox/Firefox/

+Following our design philosophy we restrict plugins a lot, but this may not be
+sufficient. Therefor we recommend not to install any Add-ons to Tor Browser.

That seems to be mixing plugins with add-ons which is confusing. I think you could just leave those two sentences out.

comment:8 Changed 2 months ago by traumschule

Status: needs_revisionneeds_review
Last edited 2 months ago by traumschule (previous) (diff)

comment:9 Changed 2 months ago by gk

Status: needs_reviewneeds_revision

Looks good. One final request: can you squash the commits and rebase against master + add a bug number to the final commit: "Bug 21263: ..."

comment:10 Changed 2 months ago by traumschule

Status: needs_revisionneeds_review
commit 02f3a9334acb1b1b72ee27c3e81013f8706f20d1 (HEAD -> master, origin/master, origin/HEAD, README)
Author: traumschule <traumschuleriebau@riseup.net>
Date:   Sat Sep 15 15:43:15 2018 +0200

    Bug 21263: Remove outdated information from the README

commit 6016a170f0266cf926b7ff305796ba83cc353536 (upstream/master)
Author: Rusty Bird <rustybird@net-c.com>
Date:   Fri Sep 14 13:05:08 2018 +0000

    Bug 27760: Fix NoScript IPC for about:blank by whitelisting messages

comment:11 Changed 2 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks! Merged to master (commit 02f3a9334acb1b1b72ee27c3e81013f8706f20d1).

Note: See TracTickets for help on using tickets.