Opened 3 years ago

Closed 3 years ago

#21268 closed defect (fixed)

e10s compatibility for New Identity

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, ff52-esr, TorBrowserTeam201703R, tbb-7.0-must
Cc: brade Actual Points:
Parent ID: #21201 Points:
Reviewer: Sponsor: Sponsor4

Description

When Firefox's multiprocess mode (aka electrolysis/e10s) is enabled, New Identity fails while trying to close all open tabs:

[...] Torbutton WARN: Unexpected error on new identity: TypeError: remove[i].contentWindow is null

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by mcs

Keywords: tbb-torbutton added; torbutton removed

comment:2 Changed 3 years ago by gk

Keywords: TorBrowserTeam201702 added

comment:3 Changed 3 years ago by gk

Sponsor: Sponsor4

Sponsor4 as well

comment:4 Changed 3 years ago by arthuredelstein

Parent ID: #21201

comment:5 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201702R added; TorBrowserTeam201702 removed
Status: newneeds_review

comment:6 Changed 3 years ago by gk

Keywords: TorBrowserTeam201703R added; TorBrowserTeam201702R removed

No February anymore.

comment:7 Changed 3 years ago by gk

Keywords: tbb-7.0-must added

comment:8 in reply to:  5 Changed 3 years ago by arthuredelstein

Replying to mcs:

Here is a patch for review:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug21268-01&id=5e5d313fa4789ee9151dc653909e95bb236ae8d4

This looks good to me and worked when I tested it. I cherry-picked it onto my latest #21201 branch.

comment:9 Changed 3 years ago by arthuredelstein

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.