Opened 6 weeks ago

Closed 5 weeks ago

Last modified 4 weeks ago

#21269 closed enhancement (implemented)

Switch IPv6Traffic to on?

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: mikeperry, adrelanos Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

dkg discovers in https://bugs.debian.org/851798 that Tor's SocksPort defaults to IPv6traffic 0.

But Tor Browser set it to 1 18 months ago in #16684.

It looks like Tor 0.2.4.7-alpha, back in 2012, decided to "wait for enough exits to support IPv6" before turning it on.

Has that time arrived?

Child Tickets

Attachments (1)

0002-set-IPv6Traffic-to-on-by-default.patch (5.4 KB) - added by dkg 5 weeks ago.
patch to enable IPv6Traffic by default

Download all attachments as: .zip

Change History (12)

comment:1 Changed 6 weeks ago by arma

GeKo tells me that Tor Browser chooses

SocksPort 9150 IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth

so it might be worthwhile to consider PreferIPv6 too.

comment:2 Changed 6 weeks ago by arma

  • Cc mikeperry added

And GeKo asked me to cc Mike so here I am doing it.

comment:3 follow-up: Changed 6 weeks ago by teor

arma said I might have an opinion, and he was right:

I think the Tor Browser default means that tor has more users with these options on than off.
If it works for Tor Browser, I can't see the harm in turning it on.

But I'd like to know what consensus weight of the total exit consensus weight supports IPv6.
(My stem isn't quite up to the task.)

(One way of increasing this proportion is to have exits automatically use IPv6 when it's available. I think there's a separate ticket for that.)

comment:4 Changed 6 weeks ago by teor

Oh, also, two other things:

  • the default-setting code for these options is duplicated in at least 3 places. There's a ticket to fix that, too.
  • I can only open https://ipv6.google.com/ in Tor Browser 1/10 times when using "New Circuit For This Site", so maybe we don't have enough IPv6 exits for PreferIPv6 yet. That said, if IPv6Traffic is off, that would be 0/10 times.

comment:5 Changed 6 weeks ago by dgoulet

  • Milestone set to Tor: 0.3.0.x-final

comment:6 Changed 6 weeks ago by nickm

I can take a patch for this, but I don't have time to write one.

Changed 5 weeks ago by dkg

patch to enable IPv6Traffic by default

comment:7 Changed 5 weeks ago by dkg

I'm using the attached patch, i think it passes the tests, and i can confirm that situations that were broken before for me (connecting to v6 hosts through a stock tor installation) are now working with this patch applied.

comment:8 in reply to: ↑ 3 Changed 5 weeks ago by cypherpunks

Replying to teor:

But I'd like to know what consensus weight of the total exit consensus weight supports IPv6.

As of onionoo data from 2017-01-23 20:00,
12.57% of exit_probability supports exiting to IPv6 according to their exit policy. I could add it to ornetstats if regularly updated data is needed.

(One way of increasing this proportion is to have exits automatically use IPv6 when it's available. I think there's a separate ticket for that.)

#5940

Last edited 5 weeks ago by cypherpunks (previous) (diff)

comment:9 Changed 5 weeks ago by dgoulet

  • Status changed from new to merge_ready

I second teor's here opinion on PreferIPv6, I fear we don't have enough Exit on IPv6 so if we get this patch in 030, let's advertise this a lot that we need Exit to start enabling IPv6 more and more! :)

I've taken dkg's patch, added a changes file and put it in branch ticket21269_030_01 (authorship has been kept).

lgtm and I confirm it's working as well! Putting that one in merge_ready so if we think it's a good idea, I think it's ready for nickm's eyes.

comment:10 Changed 5 weeks ago by nickm

  • Resolution set to implemented
  • Status changed from merge_ready to closed

lgtm; merged! Thanks to everybody who worked on this one.

comment:11 Changed 4 weeks ago by adrelanos

  • Cc adrelanos added
Note: See TracTickets for help on using tickets.