Opened 3 years ago

Closed 3 years ago

#21291 closed defect (fixed)

Relay country and flags images on search results should have alt attributes

Reported by: irl Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #21274 Points:
Reviewer: Sponsor:

Description

Currently these are rendered as:

<img data-original-title="V2Dir" class="inline flags" rel="tooltip" src="img/flags/book_14x16.png">

It's likely we can use whatever sets data-original-title as alt text.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by irl

Status: newneeds_review

Patch for this here:

https://gitweb.torproject.org/user/irl/atlas.git/patch/?id=7a56c40399a43701a0c27adfcc07382c5b0cc1bf

From 7a56c40399a43701a0c27adfcc07382c5b0cc1bf Mon Sep 17 00:00:00 2001
From: "Iain R. Learmonth" <irl@fsfe.org>
Date: Tue, 24 Jan 2017 23:01:45 +0000
Subject: Adds alt attributes to images for country flags and relay flags
 (Fixes: #21291)

In cases where there is no other text and the meaning is conveyed only in the
icon, this adds alt text explaining the icon. In cases where the icon is next
to text that explains the icon, the alt attribute is specified as an empty
string as recommended by the HTML 5 specification.

comment:2 Changed 3 years ago by irl

Owner: changed from irl to RaBe
Status: needs_reviewassigned

comment:3 Changed 3 years ago by irl

Status: assignedneeds_review

comment:4 Changed 3 years ago by RaBe

Owner: changed from RaBe to irl
Status: needs_reviewassigned

comment:5 Changed 3 years ago by RaBe

Status: assignedmerge_ready

comment:6 Changed 3 years ago by irl

Resolution: fixed
Status: merge_readyclosed

Merged and deployed (:

Thanks for the review RaBe.

Note: See TracTickets for help on using tickets.